From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: [patch 0/5] genirq: Distangle irq_request/release_resources() from irq_desc->lock Date: Thu, 29 Jun 2017 23:33:34 +0200 Message-ID: <20170629213334.375848050@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: LKML Cc: Heiko Stuebner , Julia Cartwright , Marc Zyngier , Linus Walleij , Brian Norris , Doug Anderson , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, John Keeping , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org The irq_request/release_resources() callbacks are a problem on RT as they are called under irq_desc->lock with interrupts disabled. Aside of that calling them under irq_desc->lock is conceptually wrong and has a (hard to trigger and probably theoretical) issue in free_irq(). See patch 4/5 for a detailed explanation. The series contains also a fix for the exynos gpio driver, which fiddles with the irq masking in the resource callbacks, which is bogus and potentially harmful. Finally it moves the irq timings deallocation out of the spin locked region. Thanks, tglx --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 -- include/linux/irqdesc.h | 3 + kernel/irq/irqdesc.c | 1 kernel/irq/manage.c | 47 +++++++++++++++++++------------ 4 files changed, 34 insertions(+), 21 deletions(-)