From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver
Date: Thu, 6 Jul 2017 22:50:30 +0200 [thread overview]
Message-ID: <20170706205030.e6wzn5n7ix3443cl@flea> (raw)
In-Reply-To: <20170706142822.20296-3-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote:
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */
> + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */
> + SUNXI_FUNCTION_VARIANT(0x3,
> + "pll_lock_dbg",
> + PINCTRL_SUN8I_R40)),
You have a number of lines where the wrapping is not consistent with
the rest, such as this one, but also...
> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 20),
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> - SUNXI_FUNCTION(0x2, "i2c2")), /* SCK */
> + SUNXI_FUNCTION(0x2, "i2c2"), /* SCK */
> + SUNXI_FUNCTION_VARIANT(0x4,
> + "pwm", /* PWM4 */
> + PINCTRL_SUN8I_R40)),
... this one for example. Please fix this.
Looks good otherwise.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-07-06 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:28 [PATCH 0/2] Last step to working Allwinner R40 pinctrl Icenowy Zheng
[not found] ` <20170706142822.20296-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-07-06 14:28 ` [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Icenowy Zheng
[not found] ` <20170706142822.20296-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-07-06 20:46 ` Maxime Ripard
2017-07-06 23:21 ` [linux-sunxi] " icenowy
[not found] ` <a55741a065b818d8ff3843471da61c0e-h8G6r0blFSE@public.gmane.org>
2017-07-10 8:44 ` Maxime Ripard
2017-07-10 10:23 ` Icenowy Zheng
2017-07-06 14:28 ` [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 " Icenowy Zheng
2017-07-06 20:50 ` Maxime Ripard [this message]
2017-07-06 23:13 ` Icenowy Zheng
2017-07-07 9:18 ` Maxime Ripard
2017-07-07 9:21 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706205030.e6wzn5n7ix3443cl@flea \
--to=maxime.ripard@free-electrons.com \
--cc=icenowy@aosc.io \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).