From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins
Date: Fri, 14 Jul 2017 10:35:55 -0700 [thread overview]
Message-ID: <20170714173555.GP20973@minitux> (raw)
In-Reply-To: <be10e365-95fa-dfa4-9900-4af05d8f41a9@codeaurora.org>
On Fri 14 Jul 10:01 PDT 2017, Timur Tabi wrote:
> On 07/14/2017 11:44 AM, Bjorn Andersson wrote:
> > We would have to drop the "const" on the groups arrays of the other
> > platform in order to use this, but I don't have a better suggestion at
> > this time.
>
> Why? I don't modify any data in this patch, and I build just fine with
> these options enabled:
>
> CONFIG_PINCTRL_MSM8916=y
> CONFIG_PINCTRL_MSM8994=y
> CONFIG_PINCTRL_MSM8996=y
> CONFIG_PINCTRL_QDF2XXX=m
>
What I mean is that if we want to specify that any pin of those drivers
are locked down we would make npins = 0.
But as this is a system configuration thing this information would
preferably be injected in runtime (like you do), but the
soc_data->groups arrays are currently all const (see e.g.
msm8x74_groups), so we can't change npins in runtime.
But I think this is fine for now.
Regards,
Bjorn
next prev parent reply other threads:[~2017-07-14 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:52 [PATCH 0/2] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-07-13 21:52 ` [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-07-14 16:44 ` Bjorn Andersson
2017-07-14 17:01 ` Timur Tabi
2017-07-14 17:35 ` Bjorn Andersson [this message]
2017-07-14 17:11 ` Stephen Boyd
2017-07-14 17:17 ` Timur Tabi
2017-07-14 17:23 ` Bjorn Andersson
2017-07-14 21:43 ` Timur Tabi
2017-07-14 21:46 ` Stephen Boyd
2017-07-14 22:01 ` Timur Tabi
2017-07-14 22:04 ` Stephen Boyd
2017-07-13 21:52 ` [PATCH 2/2] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
2017-07-14 17:21 ` Bjorn Andersson
2017-07-14 18:30 ` Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2017-06-30 0:42 [PATCH 1/2] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714173555.GP20973@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).