From: Lee Jones <lee.jones@linaro.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name
Date: Tue, 18 Jul 2017 08:14:17 +0100 [thread overview]
Message-ID: <20170718071417.umjdrk2cahnwqbz4@dell> (raw)
In-Reply-To: <1500297840.24690.4.camel@hadess.net>
On Mon, 17 Jul 2017, Bastien Nocera wrote:
> On Mon, 2017-07-17 at 12:58 +0100, Lee Jones wrote:
> > The commit log should not be empty.
>
> Fair.
>
> > Please provide information as to why this change is required, etc.
>
> SSIA.
Disagree. The $SUBJECT says what your intention is, but does not
describe why it's required or what tangible difference it makes to a
running system.
> I also sent another patch to the same addresses labelled:
> [PATCH] gpio: crystalcove: Uniquify driver name
Okay? I did wonder why the GPIO list was Cc'ed on this patch.
In this case the Intel guys are not listed as Maintainers for these
files, so you'll have to run ./get_maintainer.pl and pick them from
the committers entries.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-07-18 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 16:33 [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name Bastien Nocera
2017-07-17 11:58 ` Lee Jones
2017-07-17 13:24 ` Bastien Nocera
2017-07-18 7:14 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718071417.umjdrk2cahnwqbz4@dell \
--to=lee.jones@linaro.org \
--cc=hadess@hadess.net \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox