* [PATCH] pinctrl-st: fix of_irq_to_resource() result check
@ 2017-07-29 18:07 Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2017-07-29 18:07 UTC (permalink / raw)
To: Patrice Chotard, Linus Walleij, linux-gpio
Cc: linux-arm-kernel, Sergei Shtylyov
[-- Attachment #1: pinctrl-st-fix-of_irq_to_resource-result-check.patch --]
[-- Type: text/plain, Size: 978 bytes --]
of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0 in case of failure, however the ST driver still only regards
0 as failure indication -- fix it up.
Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
+++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
* [irqN]----> [gpio-bank (n)]
*/
- if (of_irq_to_resource(np, 0, &irq_res)) {
+ if (of_irq_to_resource(np, 0, &irq_res) > 0) {
gpio_irq = irq_res.start;
gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
gpio_irq, st_gpio_irq_handler);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
2017-07-29 18:07 [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
@ 2017-07-29 19:15 ` Sergei Shtylyov
2017-07-31 11:27 ` Thierry Reding
2017-08-07 9:05 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2017-07-29 19:15 UTC (permalink / raw)
To: Patrice Chotard, Linus Walleij, linux-gpio; +Cc: linux-arm-kernel
On 07/29/2017 09:07 PM, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the ST driver still only regards
> 0 as failure indication -- fix it up.
>
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
Forgot to mention that the patch is against the 'fixes' branch of Linus
W.'s 'linux-pinctrl.git' repo.
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
2017-07-29 18:07 [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
@ 2017-07-31 11:27 ` Thierry Reding
2017-07-31 11:56 ` Sergei Shtylyov
2017-08-07 9:05 ` Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2017-07-31 11:27 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Patrice Chotard, Linus Walleij, linux-gpio, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Sat, Jul 29, 2017 at 09:07:07PM +0300, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the ST driver still only regards
> 0 as failure indication -- fix it up.
>
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
> ===================================================================
> --- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
> +++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
> @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
> * [irqN]----> [gpio-bank (n)]
> */
>
> - if (of_irq_to_resource(np, 0, &irq_res)) {
> + if (of_irq_to_resource(np, 0, &irq_res) > 0) {
> gpio_irq = irq_res.start;
> gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
> gpio_irq, st_gpio_irq_handler);
While at it, maybe turn this into of_irq_get() since you only need the
interrupt number in the first place?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
2017-07-31 11:27 ` Thierry Reding
@ 2017-07-31 11:56 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2017-07-31 11:56 UTC (permalink / raw)
To: Thierry Reding
Cc: Patrice Chotard, Linus Walleij, linux-gpio, linux-arm-kernel
Hello!
On 07/31/2017 02:27 PM, Thierry Reding wrote:
>> of_irq_to_resource() has recently been fixed to return negative error #'s
>> along with 0 in case of failure, however the ST driver still only regards
>> 0 as failure indication -- fix it up.
>>
>> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> drivers/pinctrl/pinctrl-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
>> ===================================================================
>> --- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
>> +++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
>> @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
>> * [irqN]----> [gpio-bank (n)]
>> */
>>
>> - if (of_irq_to_resource(np, 0, &irq_res)) {
>> + if (of_irq_to_resource(np, 0, &irq_res) > 0) {
>> gpio_irq = irq_res.start;
>> gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
>> gpio_irq, st_gpio_irq_handler);
>
> While at it, maybe turn this into of_irq_get() since you only need the
> interrupt number in the first place?
Yeah, noticed that too. Will look into this (if I won't forget).
> Thierry
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
2017-07-29 18:07 [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
2017-07-31 11:27 ` Thierry Reding
@ 2017-08-07 9:05 ` Linus Walleij
2017-08-07 9:56 ` Sergei Shtylyov
2 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2017-08-07 9:05 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Patrice Chotard, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Sat, Jul 29, 2017 at 8:07 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the ST driver still only regards
> 0 as failure indication -- fix it up.
>
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-07 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-29 18:07 [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
2017-07-31 11:27 ` Thierry Reding
2017-07-31 11:56 ` Sergei Shtylyov
2017-08-07 9:05 ` Linus Walleij
2017-08-07 9:56 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).