From: Thierry Reding <thierry.reding@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Patrice Chotard <patrice.chotard@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl-st: fix of_irq_to_resource() result check
Date: Mon, 31 Jul 2017 13:27:19 +0200 [thread overview]
Message-ID: <20170731112719.GM26667@ulmo> (raw)
In-Reply-To: <20170729180744.873303067@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Sat, Jul 29, 2017 at 09:07:07PM +0300, Sergei Shtylyov wrote:
> of_irq_to_resource() has recently been fixed to return negative error #'s
> along with 0 in case of failure, however the ST driver still only regards
> 0 as failure indication -- fix it up.
>
> Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pinctrl/drivers/pinctrl/pinctrl-st.c
> ===================================================================
> --- linux-pinctrl.orig/drivers/pinctrl/pinctrl-st.c
> +++ linux-pinctrl/drivers/pinctrl/pinctrl-st.c
> @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru
> * [irqN]----> [gpio-bank (n)]
> */
>
> - if (of_irq_to_resource(np, 0, &irq_res)) {
> + if (of_irq_to_resource(np, 0, &irq_res) > 0) {
> gpio_irq = irq_res.start;
> gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
> gpio_irq, st_gpio_irq_handler);
While at it, maybe turn this into of_irq_get() since you only need the
interrupt number in the first place?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-31 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 18:07 [PATCH] pinctrl-st: fix of_irq_to_resource() result check Sergei Shtylyov
2017-07-29 19:15 ` Sergei Shtylyov
2017-07-31 11:27 ` Thierry Reding [this message]
2017-07-31 11:56 ` Sergei Shtylyov
2017-08-07 9:05 ` Linus Walleij
2017-08-07 9:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731112719.GM26667@ulmo \
--to=thierry.reding@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).