* [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
@ 2017-08-03 22:00 Gustavo A. R. Silva
2017-08-07 12:58 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-03 22:00 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Gustavo A. R. Silva
platform_get_irq() returns an error code, but the gpio-msic driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpio/gpio-msic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index 1b7ce7f..6cb6759 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -265,8 +265,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
int i;
if (irq < 0) {
- dev_err(dev, "no IRQ line\n");
- return -EINVAL;
+ dev_err(dev, "no IRQ line: %d\n", irq);
+ return irq;
}
if (!pdata || !pdata->gpio_base) {
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
2017-08-03 22:00 [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe() Gustavo A. R. Silva
@ 2017-08-07 12:58 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-08-07 12:58 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Fri, Aug 4, 2017 at 12:00 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> platform_get_irq() returns an error code, but the gpio-msic driver
> ignores it and always returns -EINVAL. This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly.
>
> Notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-07 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 22:00 [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe() Gustavo A. R. Silva
2017-08-07 12:58 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).