From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:PIN CONTROLLER - QUALCOMM"
<linux-arm-msm@vger.kernel.org>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: qcom: General Purpose clocks for apq8064
Date: Mon, 14 Aug 2017 08:23:41 -0700 [thread overview]
Message-ID: <20170814152341.GN29306@minitux> (raw)
In-Reply-To: <1502434516-9056-2-git-send-email-simhavcs@gmail.com>
On Thu 10 Aug 23:55 PDT 2017, Vinay Simha BN wrote:
> Add support for general purpose (GP) clocks
> for apq8064
>
> Signed-off-by: Vinay Simha BN <simhavcs@gmail.com>
>
> ---
> v1:
> * only gp_clk_1b tested in nexus7 anx7808 slimport.
> ---
> drivers/pinctrl/qcom/pinctrl-apq8064.c | 37 ++++++++++++++++++++++++++++------
> 1 file changed, 31 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-apq8064.c b/drivers/pinctrl/qcom/pinctrl-apq8064.c
[..]
> @@ -453,6 +477,7 @@ static const struct msm_function apq8064_functions[] = {
> FUNCTION(codec_mic_i2s),
> FUNCTION(codec_spkr_i2s),
> FUNCTION(gpio),
> + FUNCTION(gp_clk_1b),
You missed the others variants here.
Other than that this looks good. So please add the other 5 functions and
you can resend this with my Acked-by.
PS. For small incremental patches like this, feel free to send the DT
binding updates in the same patch as the driver changes.
Regards,
Bjorn
next prev parent reply other threads:[~2017-08-14 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 6:55 [PATCH 1/2] pinctrl: msm: GP clock for pinctrl-apq8064 binding Vinay Simha BN
2017-08-11 6:55 ` [PATCH 2/2] pinctrl: qcom: General Purpose clocks for apq8064 Vinay Simha BN
2017-08-14 15:23 ` Bjorn Andersson [this message]
2017-08-17 15:27 ` [PATCH 1/2] pinctrl: msm: GP clock for pinctrl-apq8064 binding Rob Herring
[not found] ` <1502434516-9056-1-git-send-email-simhavcs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-31 9:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814152341.GN29306@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simhavcs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).