From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org, swarren@nvidia.com,
andy.shevchenko@gmail.com, alcooperx@gmail.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 1/2] pinctrl: Allow a device to indicate when to force a state
Date: Wed, 20 Sep 2017 18:04:20 -0700 [thread overview]
Message-ID: <20170921010421.7467-2-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170921010421.7467-1-f.fainelli@gmail.com>
It may happen that a device needs to force applying a state, e.g:
because it only defines one state of pin states (default) but loses
power/register contents when entering low power modes. Add a
pinctrl_dev::flags bitmask to help describe future quirks and define
PINCTRL_FLG_FORCE_STATE as such a settable flag.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/pinctrl/core.c | 15 +++++++++++++++
drivers/pinctrl/core.h | 4 ++++
2 files changed, 19 insertions(+)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 56fbe4c3e800..c450a97de88f 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1197,11 +1197,26 @@ int pinctrl_select_state(struct pinctrl *p, struct pinctrl_state *state)
{
struct pinctrl_setting *setting, *setting2;
struct pinctrl_state *old_state = p->state;
+ bool force = false;
int ret;
if (p->state == state)
return 0;
+ if (p->state) {
+ list_for_each_entry(setting, &p->state->settings, node) {
+ if (setting->pctldev->flags & PINCTRL_FLG_FORCE_STATE)
+ force = true;
+ }
+ }
+
+ /* Some controllers may want to force this operation when they define
+ * only one set of functions and lose power state, e.g: pinctrl-single
+ * with its pinctrl-single,low-power-state-loss property.
+ */
+ if (p->state == state && !force)
+ return 0;
+
if (p->state) {
/*
* For each pinmux setting in the old state, forget SW's record
diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h
index 7880c3adc450..5fbf4dd1fa76 100644
--- a/drivers/pinctrl/core.h
+++ b/drivers/pinctrl/core.h
@@ -39,6 +39,7 @@ struct pinctrl_gpio_range;
* @hog_sleep: sleep state for pins hogged by this device
* @mutex: mutex taken on each pin controller specific action
* @device_root: debugfs root for this device
+ * @flags: feature/quirk flags
*/
struct pinctrl_dev {
struct list_head node;
@@ -63,8 +64,11 @@ struct pinctrl_dev {
#ifdef CONFIG_DEBUG_FS
struct dentry *device_root;
#endif
+ unsigned long flags;
};
+#define PINCTRL_FLG_FORCE_STATE (1 << 0)
+
/**
* struct pinctrl - per-device pin control state holder
* @node: global list node
--
2.14.1
next prev parent reply other threads:[~2017-09-21 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 1:04 [PATCH 0/2] pinctrl: Allow indicating loss of state across suspend/resume Florian Fainelli
2017-09-21 1:04 ` Florian Fainelli [this message]
2017-09-22 11:55 ` [PATCH 1/2] pinctrl: Allow a device to indicate when to force a state Linus Walleij
2017-09-22 13:20 ` Charles Keepax
2017-09-22 13:57 ` Linus Walleij
2017-09-25 19:18 ` Florian Fainelli
[not found] ` <20170922132011.wssbhnsggteffgte-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-09-22 16:57 ` Florian Fainelli
2017-09-26 14:16 ` Charles Keepax
2017-09-26 17:51 ` Florian Fainelli
2017-09-27 8:26 ` Charles Keepax
2017-09-22 12:47 ` Charles Keepax
2017-09-22 16:45 ` Florian Fainelli
2017-09-21 1:04 ` [PATCH 2/2] pinctrl: single: Allow indicating loss of pin states during low-power Florian Fainelli
[not found] ` <20170921010421.7467-3-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-22 13:03 ` Linus Walleij
2017-09-25 19:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921010421.7467-2-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).