[PATCH v2 1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment

[PATCH v2 1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment

[Wolfram Sang]

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Change since V1 for both patches:
	* corrected authorship email address (sorry for the noise!)

 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 8fc5d659e2dc01..8ca59b35595068 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -1508,7 +1508,7 @@ static const u16 pinmux_data[] = {
 };
 
 /*
- * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
+ * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.
  * Physical layout rows: A - AW, cols: 1 - 39.
  */
 #define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r))
-- 
2.11.0

[PATCH v2 2/2] pinctrl: sh-pfc: r8a7796: fix trivial typo in comment

[Wolfram Sang]

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index 200e1f4f6db92b..81d5ef3744fbdb 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -495,7 +495,7 @@ FM(IP16_31_28)	IP16_31_28	FM(IP17_31_28)	IP17_31_28
 #define MOD_SEL1_1		FM(SEL_PWM2_0)		FM(SEL_PWM2_1)
 #define MOD_SEL1_0		FM(SEL_PWM1_0)		FM(SEL_PWM1_1)
 
-/* MOD_SEL1 */			/* 0 */			/* 1 */			/* 2 */			/* 3 */			/* 4 */			/* 5 */			/* 6 */			/* 7 */
+/* MOD_SEL2 */			/* 0 */			/* 1 */			/* 2 */			/* 3 */			/* 4 */			/* 5 */			/* 6 */			/* 7 */
 #define MOD_SEL2_31		FM(I2C_SEL_5_0)		FM(I2C_SEL_5_1)
 #define MOD_SEL2_30		FM(I2C_SEL_3_0)		FM(I2C_SEL_3_1)
 #define MOD_SEL2_29		FM(I2C_SEL_0_0)		FM(I2C_SEL_0_1)
-- 
2.11.0

Re: [PATCH v2 1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, Oct 9, 2017 at 10:37 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since V1 for both patches:
>         * corrected authorship email address (sorry for the noise!)
>
>  drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> index 8fc5d659e2dc01..8ca59b35595068 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -1508,7 +1508,7 @@ static const u16 pinmux_data[] = {
>  };
>
>  /*
> - * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
> + * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.

I don't think the capitalization of "in each" had to be changed?
(overzealous use of vim ~?)

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v4.15 with the above fixed, and once more
after filtering through s/r8a7795/r8a7795-es1/g.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 2/2] pinctrl: sh-pfc: r8a7796: fix trivial typo in comment

[Geert Uytterhoeven]

On Mon, Oct 9, 2017 at 10:37 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v4.15.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 1/2] pinctrl: sh-pfc: r8a7795: fix trivial typo in comment

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]


> > - * R8A7795 has 8 banks with 32 PGIOS in each => 256 GPIOs.
> > + * R8A7795 has 8 banks with 32 GPIOs IN EACH => 256 GPIOs.
> 
> I don't think the capitalization of "in each" had to be changed?
> (overzealous use of vim ~?)

Huh, how did this slip through? Sorry, Geert, and thanks for updating
it.

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in sh-pfc-for-v4.15 with the above fixed, and once more
> after filtering through s/r8a7795/r8a7795-es1/g.

Good. I got the idea of checking es1 yesterday on the train, too, but
didn't come around to do it yet.

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]