linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 04/13] gpio: Move irq_base to struct gpio_irq_chip
Date: Fri, 13 Oct 2017 17:49:04 +0200	[thread overview]
Message-ID: <20171013154913.29448-5-thierry.reding@gmail.com> (raw)
In-Reply-To: <20171013154913.29448-1-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

In order to consolidate the multiple ways to associate an IRQ chip with
a GPIO chip, move more fields into the new struct gpio_irq_chip.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c |  2 +-
 include/linux/gpio/driver.h                 | 10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index c9851bd120b4..500238d898ea 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -627,7 +627,7 @@ static void armada_37xx_irq_handler(struct irq_desc *desc)
 static unsigned int armada_37xx_irq_startup(struct irq_data *d)
 {
 	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
-	int irq = d->hwirq - chip->irq_base;
+	int irq = d->hwirq - chip->irq.first;
 	/*
 	 * The mask field is a "precomputed bitmask for accessing the
 	 * chip registers" which was introduced for the generic
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 794bc6058282..20a056e13f60 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -46,6 +46,14 @@ struct gpio_irq_chip {
 	 */
 	const struct irq_domain_ops *domain_ops;
 
+	/**
+	 * @first:
+	 *
+	 * If not dynamically assigned, the base (first) IRQ to allocate GPIO
+	 * chip IRQs from (deprecated).
+	 */
+	unsigned int first;
+
 	/**
 	 * @parent_handler:
 	 *
@@ -130,7 +138,6 @@ static inline struct gpio_irq_chip *to_gpio_irq_chip(struct irq_chip *chip)
  *	safely.
  * @bgpio_dir: shadowed direction register for generic GPIO to clear/set
  *	direction safely.
- * @irq_base: first linux IRQ number assigned to GPIO IRQ chip (deprecated)
  * @irq_handler: the irq handler to use (often a predefined irq core function)
  *	for GPIO IRQs, provided by GPIO driver
  * @irq_default_type: default IRQ triggering type applied during GPIO driver
@@ -210,7 +217,6 @@ struct gpio_chip {
 	 * With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib
 	 * to handle IRQs for most practical cases.
 	 */
-	unsigned int		irq_base;
 	irq_flow_handler_t	irq_handler;
 	unsigned int		irq_default_type;
 	unsigned int		irq_chained_parent;
-- 
2.14.1

  parent reply	other threads:[~2017-10-13 15:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 15:49 [PATCH v5 00/13] gpio: Tight IRQ chip integration Thierry Reding
2017-10-13 15:49 ` [PATCH v5 01/13] gpio: Introduce struct gpio_irq_chip Thierry Reding
2017-10-13 15:49 ` [PATCH v5 02/13] gpio: Move irqchip into " Thierry Reding
2017-10-13 15:49 ` [PATCH v5 03/13] gpio: Move irqdomain " Thierry Reding
2017-10-13 15:49 ` Thierry Reding [this message]
2017-10-13 15:49 ` [PATCH v5 05/13] gpio: Move irq_handler to " Thierry Reding
2017-10-13 15:49 ` [PATCH v5 06/13] gpio: Move irq_default_type " Thierry Reding
2017-10-13 15:49 ` [PATCH v5 07/13] gpio: Move irq_chained_parent " Thierry Reding
2017-10-13 15:49 ` [PATCH v5 08/13] gpio: Move irq_nested into " Thierry Reding
     [not found] ` <20171013154913.29448-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-13 15:49   ` [PATCH v5 09/13] gpio: Move irq_valid_mask " Thierry Reding
2017-10-16 18:09   ` [PATCH v5 00/13] gpio: Tight IRQ chip integration Jon Hunter
     [not found]     ` <f25cd66f-1382-8007-9744-0dbd72757163-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-10-23  8:47       ` Jon Hunter
2017-10-26  7:18         ` Jon Hunter
2017-11-01 13:44           ` Linus Walleij
2017-10-13 15:49 ` [PATCH v5 10/13] gpio: Move lock_key into struct gpio_irq_chip Thierry Reding
2017-10-13 15:49 ` [PATCH v5 11/13] gpio: Implement tighter IRQ chip integration Thierry Reding
2017-10-13 15:49 ` [PATCH v5 12/13] gpio: Export gpiochip_irq_{map,unmap}() Thierry Reding
2017-10-13 15:49 ` [PATCH v5 13/13] gpio: Add Tegra186 support Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013154913.29448-5-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=jonathanh@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).