From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: fenglinw@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, collinsd@codeaurora.org,
aghayal@codeaurora.org, wruan@codeaurora.org,
subbaram@codeaurora.org, kgunda@codeaurora.org
Subject: Re: [PATCH V1 1/2] pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state
Date: Mon, 16 Oct 2017 15:19:01 -0700 [thread overview]
Message-ID: <20171016221901.GP1165@minitux> (raw)
In-Reply-To: <20171013061550.996-2-fenglinw@codeaurora.org>
On Thu 12 Oct 23:15 PDT 2017, fenglinw@codeaurora.org wrote:
> From: Fenglin Wu <fenglinw@codeaurora.org>
>
> Get initial value of is_enabled flag by reading REG_EN_CTL register
> so that it can reflect the correct hardware enable state before
> setting pin config.
>
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index a0edaa8..0a1e173 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -106,6 +106,7 @@
>
> /* PMIC_GPIO_REG_EN_CTL */
> #define PMIC_GPIO_REG_MASTER_EN_SHIFT 7
> +#define PMIC_GPIO_REG_MASTER_EN 0x80
>
> #define PMIC_GPIO_PHYSICAL_OFFSET 1
>
> @@ -914,8 +915,12 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state,
> pad->atest = (val & PMIC_GPIO_LV_MV_ANA_MUX_SEL_MASK) + 1;
> }
>
> - /* Pin could be disabled with PIN_CONFIG_BIAS_HIGH_IMPEDANCE */
> - pad->is_enabled = true;
> + val = pmic_gpio_read(state, pad, PMIC_GPIO_REG_EN_CTL);
> + if (val < 0)
> + return val;
> +
> + pad->is_enabled = val & PMIC_GPIO_REG_MASTER_EN;
Please be more explicit here: is_enable = !!(val & ...)
> +
other than that,
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
next prev parent reply other threads:[~2017-10-16 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171013061550.996-1-fenglinw@codeaurora.org>
2017-10-13 6:15 ` [PATCH V1 1/2] pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state fenglinw
2017-10-16 22:19 ` Bjorn Andersson [this message]
2017-10-13 6:15 ` [PATCH V1 2/2] pinctrl: qcom: spmi-gpio: Set is_enabled flag in set_mux() fenglinw
2017-10-16 22:29 ` Bjorn Andersson
2017-10-17 4:36 ` Fenglin Wu
2017-10-20 9:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016221901.GP1165@minitux \
--to=bjorn.andersson@linaro.org \
--cc=aghayal@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=fenglinw@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=wruan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).