* [PATCH] gpio: dwapb: fix bgpio usage
@ 2017-10-20 10:29 Linus Walleij
2017-10-24 20:22 ` Alan Tull
2017-10-24 20:26 ` Hoan Tran
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2017-10-20 10:29 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Hoan Tran, Alan Tull
The DW APB GPIO driver uses the generic GPIO library gpio-mmio,
and initialize the flags as "false", which should be 0.
When no flags are given, the native endianness is used to access
the MMIO registers, and the pin2mask() call can simply be
converted to a BIT() call, as per the default pin2mask()
implementation in gpio-mmio.c.
Cc: Hoan Tran <hotran@apm.com>
Cc: Alan Tull <atull@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-dwapb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index d782ad195c89..6730c6642ce3 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -320,7 +320,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc,
struct dwapb_gpio_port *port = gpiochip_get_data(gc);
struct dwapb_gpio *gpio = port->gpio;
unsigned long flags, val_deb;
- unsigned long mask = gc->pin2mask(gc, offset);
+ unsigned long mask = BIT(offset);
spin_lock_irqsave(&gc->bgpio_lock, flags);
@@ -482,7 +482,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
(pp->idx * GPIO_SWPORT_DDR_SIZE);
err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,
- NULL, false);
+ NULL, 0);
if (err) {
dev_err(gpio->dev, "failed to init gpio chip for port%d\n",
port->idx);
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: dwapb: fix bgpio usage
2017-10-20 10:29 [PATCH] gpio: dwapb: fix bgpio usage Linus Walleij
@ 2017-10-24 20:22 ` Alan Tull
2017-10-24 20:26 ` Hoan Tran
1 sibling, 0 replies; 3+ messages in thread
From: Alan Tull @ 2017-10-24 20:22 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio@vger.kernel.org, Hoan Tran
On Fri, Oct 20, 2017 at 5:29 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> The DW APB GPIO driver uses the generic GPIO library gpio-mmio,
> and initialize the flags as "false", which should be 0.
>
> When no flags are given, the native endianness is used to access
> the MMIO registers, and the pin2mask() call can simply be
> converted to a BIT() call, as per the default pin2mask()
> implementation in gpio-mmio.c.
>
> Cc: Hoan Tran <hotran@apm.com>
> Cc: Alan Tull <atull@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Alan Tull <atull@kernel.org>
> ---
> drivers/gpio/gpio-dwapb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index d782ad195c89..6730c6642ce3 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -320,7 +320,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc,
> struct dwapb_gpio_port *port = gpiochip_get_data(gc);
> struct dwapb_gpio *gpio = port->gpio;
> unsigned long flags, val_deb;
> - unsigned long mask = gc->pin2mask(gc, offset);
> + unsigned long mask = BIT(offset);
>
> spin_lock_irqsave(&gc->bgpio_lock, flags);
>
> @@ -482,7 +482,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> (pp->idx * GPIO_SWPORT_DDR_SIZE);
>
> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,
> - NULL, false);
> + NULL, 0);
> if (err) {
> dev_err(gpio->dev, "failed to init gpio chip for port%d\n",
> port->idx);
> --
> 2.13.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: dwapb: fix bgpio usage
2017-10-20 10:29 [PATCH] gpio: dwapb: fix bgpio usage Linus Walleij
2017-10-24 20:22 ` Alan Tull
@ 2017-10-24 20:26 ` Hoan Tran
1 sibling, 0 replies; 3+ messages in thread
From: Hoan Tran @ 2017-10-24 20:26 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Alan Tull
Hi Linus,
On Fri, Oct 20, 2017 at 3:29 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> The DW APB GPIO driver uses the generic GPIO library gpio-mmio,
> and initialize the flags as "false", which should be 0.
>
> When no flags are given, the native endianness is used to access
> the MMIO registers, and the pin2mask() call can simply be
> converted to a BIT() call, as per the default pin2mask()
> implementation in gpio-mmio.c.
>
> Cc: Hoan Tran <hotran@apm.com>
> Cc: Alan Tull <atull@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-dwapb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index d782ad195c89..6730c6642ce3 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -320,7 +320,7 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc,
> struct dwapb_gpio_port *port = gpiochip_get_data(gc);
> struct dwapb_gpio *gpio = port->gpio;
> unsigned long flags, val_deb;
> - unsigned long mask = gc->pin2mask(gc, offset);
> + unsigned long mask = BIT(offset);
>
> spin_lock_irqsave(&gc->bgpio_lock, flags);
>
> @@ -482,7 +482,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
> (pp->idx * GPIO_SWPORT_DDR_SIZE);
>
> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,
> - NULL, false);
> + NULL, 0);
> if (err) {
> dev_err(gpio->dev, "failed to init gpio chip for port%d\n",
> port->idx);
> --
> 2.13.6
>
Acked-by: Hoan Tran <hotran@apm.com>
Regards
Hoan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-24 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 10:29 [PATCH] gpio: dwapb: fix bgpio usage Linus Walleij
2017-10-24 20:22 ` Alan Tull
2017-10-24 20:26 ` Hoan Tran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).