From: Doug Berger <opendmb@gmail.com>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/7] gpio: brcmstb: correct the configuration of level interrupts
Date: Tue, 24 Oct 2017 12:54:49 -0700 [thread overview]
Message-ID: <20171024195451.30535-6-opendmb@gmail.com> (raw)
In-Reply-To: <20171024195451.30535-1-opendmb@gmail.com>
This commit corrects a bug when configuring the GPIO hardware for
IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_LEVEL_HIGH interrupt types. The
hardware is now correctly configured to support those types.
Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
Signed-off-by: Doug Berger <opendmb@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
---
drivers/gpio/gpio-brcmstb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 513de4936a25..183863902f7f 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -137,13 +137,13 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type)
switch (type) {
case IRQ_TYPE_LEVEL_LOW:
- level = 0;
+ level = mask;
edge_config = 0;
edge_insensitive = 0;
break;
case IRQ_TYPE_LEVEL_HIGH:
level = mask;
- edge_config = 0;
+ edge_config = mask;
edge_insensitive = 0;
break;
case IRQ_TYPE_EDGE_FALLING:
--
2.14.1
next prev parent reply other threads:[~2017-10-24 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 19:54 [PATCH v2 0/7] gpio: brcmstb: improved interrupt and wake support Doug Berger
2017-10-24 19:54 ` [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask() Doug Berger
2017-10-28 16:54 ` Florian Fainelli
2017-10-24 19:54 ` [PATCH v2 2/7] gpio: brcmstb: allow all instances to be wakeup sources Doug Berger
2017-10-31 9:28 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 3/7] gpio: brcmstb: release the bgpio lock during irq handlers Doug Berger
2017-10-31 9:29 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 4/7] gpio: brcmstb: switch to handle_level_irq flow Doug Berger
2017-10-31 9:30 ` Linus Walleij
2017-10-24 19:54 ` Doug Berger [this message]
2017-10-31 9:31 ` [PATCH v2 5/7] gpio: brcmstb: correct the configuration of level interrupts Linus Walleij
2017-10-24 19:54 ` [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains Doug Berger
2017-10-26 23:44 ` Gregory Fong
2017-10-28 16:56 ` Florian Fainelli
2017-10-31 9:34 ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 7/7] gpio: brcmstb: implement suspend/resume/shutdown Doug Berger
2017-10-26 23:51 ` Gregory Fong
2017-10-28 16:58 ` Florian Fainelli
2017-10-31 9:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024195451.30535-6-opendmb@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).