From: Stephen Boyd <sboyd@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
thierry.reding@gmail.com, david.brown@linaro.org,
andy.gross@linaro.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 3/4] [v6] pinctrl: qcom: disable GPIO groups with no pins
Date: Thu, 16 Nov 2017 18:43:32 -0800 [thread overview]
Message-ID: <20171117024332.GU11955@codeaurora.org> (raw)
In-Reply-To: <1510096056-13765-4-git-send-email-timur@codeaurora.org>
On 11/07, Timur Tabi wrote:
> pinctrl-msm only accepts an array of GPIOs from 0 to n-1, and it expects
> each group to support have only one pin (npins == 1).
>
> We can support "sparse" GPIO maps if we allow for some groups to have zero
> pins (npins == 0). These pins are "hidden" from the rest of the driver
> and gpiolib.
>
> A new boolean 'sparse' indicates whether the GPIO map is sparse. If any
> GPIO has an 'npins' value of 0, then 'sparse' must be set to True.
>
> Most access to unavailable GPIOs can be blocked via the gpio_chip.request
> function. The one exception is when gpiochip_add_data() scans all of
If patch 1 is applied is this statement still true?
> the GPIOs without "requesting" them. To cover this case,
s/GPIOs/GPIOs for their direction/ perhaps?
> msm_gpio_get_direction() separately checks if the GPIO is available.
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-17 2:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 23:07 [PATCH 0/4] [v7] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-11-07 23:07 ` [PATCH 1/4] [v2] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-11-07 23:07 ` [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines Timur Tabi
[not found] ` <b2b5374b-17a6-e068-ef8b-edc90d34c352@codeaurora.org>
2017-11-15 6:28 ` Fwd: " Varadarajan Narayanan
2017-11-15 11:38 ` Andy Shevchenko
2017-11-15 15:15 ` Timur Tabi
2017-12-01 11:38 ` Archit Taneja
2017-12-01 17:16 ` Timur Tabi
2017-11-07 23:07 ` [PATCH 3/4] [v6] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-11-17 2:43 ` Stephen Boyd [this message]
2017-11-17 2:58 ` Timur Tabi
2017-11-17 17:46 ` Stephen Boyd
2017-11-17 17:49 ` Timur Tabi
2017-11-17 21:42 ` Stephen Boyd
2017-11-17 21:44 ` Timur Tabi
2017-11-07 23:07 ` [PATCH 4/4] [v3] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
[not found] ` <133cd447-c5c8-2b3e-1ae2-484307d5e39d@codeaurora.org>
2017-11-15 6:47 ` Fwd: " Varadarajan Narayanan
2017-11-15 15:14 ` Timur Tabi
2017-11-13 19:19 ` [PATCH 0/4] [v7] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-11-13 21:49 ` Linus Walleij
2017-11-13 21:53 ` Timur Tabi
2017-11-14 10:03 ` Linus Walleij
2017-11-15 15:06 ` Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2017-10-30 20:49 [PATCH 0/4] [v6] " Timur Tabi
2017-10-30 20:50 ` [PATCH 3/4] [v6] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117024332.GU11955@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).