From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-gpio@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: sh-pfc: r8a7795: Add SATA pins, groups, and functions
Date: Thu, 21 Dec 2017 12:52:37 +0100 [thread overview]
Message-ID: <20171221115237.vy42lxqo2igygbg2@ninjato> (raw)
In-Reply-To: <CAMuHMdWC9B9YtDzHJ21zLrzMx8JJxUC5q9LRz3c-Kv2y6M+Y9A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Hi Geert,
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in sh-pfc-for-v4.16.
Thanks for the fast review!
>
> > Note: To repeat the test you must:
> > a) switch pin7 from SW12 to OFF
>
> Funny how the relation of MD12 to SATA is mentioned only in the Salvator-XS
> hardware manual, but not in the R-Car Gen3 User's Manual? Or did I miss it?
I just followed the XS manual, to be honest.
> > b) set an external GPIO to 0 by using these commands:
> > i2cset -y 4 0x20 3 0x7f (set pin to output)
> > i2cset -y 4 0x20 1 0x7f (set pin to 0)
>
> Time to add the PCA9654 to the DTS, so users can use a gpio-hog instead?
Yes, I'll send some patches (with questions) in a minute. Just wanted to
check if this one is OK.
See you in a minute ;)
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-12-21 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 21:59 [PATCH] pinctrl: sh-pfc: r8a7795: Add SATA pins, groups, and functions Wolfram Sang
2017-12-21 9:07 ` Geert Uytterhoeven
2017-12-21 11:52 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221115237.vy42lxqo2igygbg2@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).