From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] pinctrl/spear/plgpio: Delete two error messages for a failed memory allocation in plgpio_probe() Date: Thu, 28 Dec 2017 10:56:46 +0530 Message-ID: <20171228052646.GC8652@vireshk-i7> References: <66c3f488-ffdf-e55d-e511-e4af35e670b4@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:39269 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbdL1F0u (ORCPT ); Thu, 28 Dec 2017 00:26:50 -0500 Received: by mail-pl0-f66.google.com with SMTP id bi12so20620797plb.6 for ; Wed, 27 Dec 2017 21:26:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <66c3f488-ffdf-e55d-e511-e4af35e670b4@users.sourceforge.net> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: SF Markus Elfring Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Viresh Kumar , LKML , kernel-janitors@vger.kernel.org On 27-12-17, 22:39, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 27 Dec 2017 22:34:28 +0100 > > Omit extra messages for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/pinctrl/spear/pinctrl-plgpio.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c > index 6a0ed8ab33b9..d2123e396b29 100644 > --- a/drivers/pinctrl/spear/pinctrl-plgpio.c > +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c > @@ -519,10 +519,8 @@ static int plgpio_probe(struct platform_device *pdev) > int ret, irq; > > plgpio = devm_kzalloc(&pdev->dev, sizeof(*plgpio), GFP_KERNEL); > - if (!plgpio) { > - dev_err(&pdev->dev, "memory allocation fail\n"); > + if (!plgpio) > return -ENOMEM; > - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > plgpio->base = devm_ioremap_resource(&pdev->dev, res); > @@ -544,10 +542,8 @@ static int plgpio_probe(struct platform_device *pdev) > sizeof(*plgpio->csave_regs) * > DIV_ROUND_UP(plgpio->chip.ngpio, MAX_GPIO_PER_REG), > GFP_KERNEL); > - if (!plgpio->csave_regs) { > - dev_err(&pdev->dev, "csave registers memory allocation fail\n"); > + if (!plgpio->csave_regs) > return -ENOMEM; > - } > #endif > > platform_set_drvdata(pdev, plgpio); Acked-by: Viresh Kumar -- viresh