* [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
@ 2018-01-09 16:40 kbuild test robot
2018-01-10 18:11 ` Stefan Agner
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2018-01-09 16:40 UTC (permalink / raw)
To: Bai Ping; +Cc: kbuild-all, linux-gpio, Linus Walleij, Stefan Agner, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
head: a3a093ae02e2ae81499ad9e78516dccd72906c25
commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
# save the attached .config to linux build tree
make.cross ARCH=arm
All warnings (new ones prefixed by >>):
drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function 'imx6ul_pinctrl_probe':
>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
return imx_pinctrl_probe(pdev, pinctrl_info);
^~~~~~~~~~~~
In file included from drivers/pinctrl/freescale/pinctrl-imx6ul.c:19:0:
drivers/pinctrl/freescale/pinctrl-imx.h:119:5: note: expected 'struct imx_pinctrl_soc_info *' but argument is of type 'const struct imx_pinctrl_soc_info *'
int imx_pinctrl_probe(struct platform_device *pdev,
^~~~~~~~~~~~~~~~~
vim +343 drivers/pinctrl/freescale/pinctrl-imx6ul.c
334
335 static int imx6ul_pinctrl_probe(struct platform_device *pdev)
336 {
337 const struct imx_pinctrl_soc_info *pinctrl_info;
338
339 pinctrl_info = of_device_get_match_data(&pdev->dev);
340 if (!pinctrl_info)
341 return -ENODEV;
342
> 343 return imx_pinctrl_probe(pdev, pinctrl_info);
344 }
345
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42744 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
2018-01-09 16:40 [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type kbuild test robot
@ 2018-01-10 18:11 ` Stefan Agner
2018-01-11 9:21 ` Linus Walleij
2018-01-11 9:32 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Agner @ 2018-01-10 18:11 UTC (permalink / raw)
To: Linus Walleij
Cc: Bai Ping, kbuild-all, linux-gpio, Rob Herring, kbuild test robot
Hi Linus,
On 2018-01-09 17:40, kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
> devel
> head: a3a093ae02e2ae81499ad9e78516dccd72906c25
> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
> config: arm-multi_v7_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
> # save the attached .config to linux build tree
> make.cross ARCH=arm
>
> All warnings (new ones prefixed by >>):
>
> drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
> 'imx6ul_pinctrl_probe':
>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> return imx_pinctrl_probe(pdev, pinctrl_info);
> ^~~~~~~~~~~~
I think this happened because you only applied patch 5 of the imx
constify patchset, is that correct?
Let me know if you expect me to do something.
--
Stefan
> In file included from drivers/pinctrl/freescale/pinctrl-imx6ul.c:19:0:
> drivers/pinctrl/freescale/pinctrl-imx.h:119:5: note: expected
> 'struct imx_pinctrl_soc_info *' but argument is of type 'const struct
> imx_pinctrl_soc_info *'
> int imx_pinctrl_probe(struct platform_device *pdev,
> ^~~~~~~~~~~~~~~~~
>
> vim +343 drivers/pinctrl/freescale/pinctrl-imx6ul.c
>
> 334
> 335 static int imx6ul_pinctrl_probe(struct platform_device *pdev)
> 336 {
> 337 const struct imx_pinctrl_soc_info *pinctrl_info;
> 338
> 339 pinctrl_info = of_device_get_match_data(&pdev->dev);
> 340 if (!pinctrl_info)
> 341 return -ENODEV;
> 342
> > 343 return imx_pinctrl_probe(pdev, pinctrl_info);
> 344 }
> 345
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
2018-01-10 18:11 ` Stefan Agner
@ 2018-01-11 9:21 ` Linus Walleij
2018-01-11 9:32 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2018-01-11 9:21 UTC (permalink / raw)
To: Stefan Agner
Cc: Bai Ping, kbuild-all, linux-gpio, Rob Herring, kbuild test robot
On Wed, Jan 10, 2018 at 7:11 PM, Stefan Agner <stefan@agner.ch> wrote:
> Hi Linus,
>
> On 2018-01-09 17:40, kbuild test robot wrote:
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
>> devel
>> head: a3a093ae02e2ae81499ad9e78516dccd72906c25
>> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
>> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
>> config: arm-multi_v7_defconfig (attached as .config)
>> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
>> # save the attached .config to linux build tree
>> make.cross ARCH=arm
>>
>> All warnings (new ones prefixed by >>):
>>
>> drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
>> 'imx6ul_pinctrl_probe':
>>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>> return imx_pinctrl_probe(pdev, pinctrl_info);
>> ^~~~~~~~~~~~
>
>
> I think this happened because you only applied patch 5 of the imx
> constify patchset, is that correct?
I guess... I'm looking it over.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
2018-01-10 18:11 ` Stefan Agner
2018-01-11 9:21 ` Linus Walleij
@ 2018-01-11 9:32 ` Linus Walleij
2018-01-11 12:27 ` Stefan Agner
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2018-01-11 9:32 UTC (permalink / raw)
To: Stefan Agner
Cc: Bai Ping, kbuild-all, linux-gpio, Rob Herring, kbuild test robot
On Wed, Jan 10, 2018 at 7:11 PM, Stefan Agner <stefan@agner.ch> wrote:
> Hi Linus,
>
> On 2018-01-09 17:40, kbuild test robot wrote:
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
>> devel
>> head: a3a093ae02e2ae81499ad9e78516dccd72906c25
>> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
>> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
>> config: arm-multi_v7_defconfig (attached as .config)
>> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
>> # save the attached .config to linux build tree
>> make.cross ARCH=arm
>>
>> All warnings (new ones prefixed by >>):
>>
>> drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
>> 'imx6ul_pinctrl_probe':
>>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>> return imx_pinctrl_probe(pdev, pinctrl_info);
>> ^~~~~~~~~~~~
>
>
> I think this happened because you only applied patch 5 of the imx
> constify patchset, is that correct?
I have applied patches 1-4 now... patch 5 I can't even find in
my inbox :(
So I guess not.
Can you have a look at my devel branch and send or resend a
patch if something is still wrong?
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
2018-01-11 9:32 ` Linus Walleij
@ 2018-01-11 12:27 ` Stefan Agner
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Agner @ 2018-01-11 12:27 UTC (permalink / raw)
To: Linus Walleij
Cc: Bai Ping, kbuild-all, linux-gpio, Rob Herring, kbuild test robot
On 2018-01-11 10:32, Linus Walleij wrote:
> On Wed, Jan 10, 2018 at 7:11 PM, Stefan Agner <stefan@agner.ch> wrote:
>> Hi Linus,
>>
>> On 2018-01-09 17:40, kbuild test robot wrote:
>>> tree:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
>>> devel
>>> head: a3a093ae02e2ae81499ad9e78516dccd72906c25
>>> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
>>> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
>>> config: arm-multi_v7_defconfig (attached as .config)
>>> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>>> reproduce:
>>> wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=arm
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
>>> 'imx6ul_pinctrl_probe':
>>>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>>> return imx_pinctrl_probe(pdev, pinctrl_info);
>>> ^~~~~~~~~~~~
>>
>>
>> I think this happened because you only applied patch 5 of the imx
>> constify patchset, is that correct?
>
> I have applied patches 1-4 now... patch 5 I can't even find in
> my inbox :(
>
> So I guess not.
>
> Can you have a look at my devel branch and send or resend a
> patch if something is still wrong?
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
All patches are applied now. Note that Patch 5 ("pinctrl: imx6ul: add
IOMUXC SNVS pinctrl driver for i.MX 6ULL") is not authored by me, so
that is a bit confusing when looking at the git history.
The above warning has been triggered because patch 5 has been applied
before patch 1. I guess for strict bisectability it should be
reordered.. ("pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX
6ULL" should be after "pinctrl: imx: use struct imx_pinctrl_soc_info as
a const").
--
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-11 12:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 16:40 [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type kbuild test robot
2018-01-10 18:11 ` Stefan Agner
2018-01-11 9:21 ` Linus Walleij
2018-01-11 9:32 ` Linus Walleij
2018-01-11 12:27 ` Stefan Agner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).