From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-gpio@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: add required properties to example in bindings
Date: Sun, 21 Jan 2018 13:37:15 +0100 [thread overview]
Message-ID: <20180121123715.q6f5agmrd2giv6o6@ninjato> (raw)
In-Reply-To: <CAMuHMdURWa9z5_zewz-MQph_g=3MTk3f+QnUmULMbugb6qmNOQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
> > +- gpio-controller: Marks the device node as a GPIO controller
> > +- #gpio-cells: Must be '2':
> > + - First cell is the GPIO line number
> > + - Second cell is for optional parameters (currently unused)
>
> Is it really unused?
>
> I'd expect at least GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW to work,
> cfr. Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
I rephrased it in a way which should be correct and no get stale over
time. Will send it right away.
> > @@ -44,4 +49,6 @@ Example:
> > pinctrl-0 = <&pinctrl_pca9505>;
> > interrupt-parent = <&gpio3>;
> > interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
>
> Note that interrupts is also not documented.
I vote for incremental changes. I haven't tested that yet.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-01-21 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 20:09 [PATCH] gpio: pca953x: add required properties to example in bindings Wolfram Sang
2018-01-03 10:36 ` Geert Uytterhoeven
2018-01-21 12:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121123715.q6f5agmrd2giv6o6@ninjato \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox