* [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
@ 2018-04-30 13:22 Colin King
2018-04-30 13:51 ` Manivannan Sadhasivam
2018-05-02 11:47 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-04-30 13:22 UTC (permalink / raw)
To: Linus Walleij, Manivannan Sadhasivam, linux-gpio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
checks against *arg. This looks like an unintentional missing break so
add in the break.
Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch")
Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/actions/pinctrl-owl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 928b40f71a3c..ee090697b1e9 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g,
default:
return -EINVAL;
}
+ break;
case PIN_CONFIG_SLEW_RATE:
if (*arg)
*arg = OWL_PINCONF_SLEW_FAST;
@@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g,
default:
return -EINVAL;
}
+ break;
case PIN_CONFIG_SLEW_RATE:
if (*arg)
*arg = 1;
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
2018-04-30 13:22 [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case Colin King
@ 2018-04-30 13:51 ` Manivannan Sadhasivam
2018-05-02 11:47 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2018-04-30 13:51 UTC (permalink / raw)
To: Colin King; +Cc: Linus Walleij, linux-gpio, kernel-janitors, linux-kernel
On Mon, Apr 30, 2018 at 02:22:59PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
> a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
> checks against *arg. This looks like an unintentional missing break so
> add in the break.
>
> Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch")
>
Thanks for fixing!
> Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
> index 928b40f71a3c..ee090697b1e9 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g,
> default:
> return -EINVAL;
> }
> + break;
> case PIN_CONFIG_SLEW_RATE:
> if (*arg)
> *arg = OWL_PINCONF_SLEW_FAST;
> @@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g,
> default:
> return -EINVAL;
> }
> + break;
> case PIN_CONFIG_SLEW_RATE:
> if (*arg)
> *arg = 1;
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
2018-04-30 13:22 [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case Colin King
2018-04-30 13:51 ` Manivannan Sadhasivam
@ 2018-05-02 11:47 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-05-02 11:47 UTC (permalink / raw)
To: Colin King
Cc: Manivannan Sadhasivam, open list:GPIO SUBSYSTEM, kernel-janitors,
linux-kernel@vger.kernel.org
On Mon, Apr 30, 2018 at 3:22 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
> a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
> checks against *arg. This looks like an unintentional missing break so
> add in the break.
>
> Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch")
>
> Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This v2 applied with Manivannan's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-02 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-30 13:22 [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case Colin King
2018-04-30 13:51 ` Manivannan Sadhasivam
2018-05-02 11:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).