From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manivannan Sadhasivam Subject: Re: [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case. Date: Mon, 30 Apr 2018 19:21:49 +0530 Message-ID: <20180430135149.mn4ywt6i73ocoobk@linaro.org> References: <20180430132259.9938-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180430132259.9938-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Linus Walleij , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Mon, Apr 30, 2018 at 02:22:59PM +0100, Colin King wrote: > From: Colin Ian King > > There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to > a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different > checks against *arg. This looks like an unintentional missing break so > add in the break. > > Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch") > Thanks for fixing! > Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver") > Signed-off-by: Colin Ian King Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pinctrl/actions/pinctrl-owl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c > index 928b40f71a3c..ee090697b1e9 100644 > --- a/drivers/pinctrl/actions/pinctrl-owl.c > +++ b/drivers/pinctrl/actions/pinctrl-owl.c > @@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g, > default: > return -EINVAL; > } > + break; > case PIN_CONFIG_SLEW_RATE: > if (*arg) > *arg = OWL_PINCONF_SLEW_FAST; > @@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g, > default: > return -EINVAL; > } > + break; > case PIN_CONFIG_SLEW_RATE: > if (*arg) > *arg = 1; > -- > 2.17.0 >