From: Tony Lindgren <tony@atomide.com>
To: Keerthy <j-keerthy@ti.com>
Cc: t-kristo@ti.com, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl context
Date: Wed, 16 May 2018 08:22:41 -0700 [thread overview]
Message-ID: <20180516152241.GF98604@atomide.com> (raw)
In-Reply-To: <1526449230-27618-3-git-send-email-j-keerthy@ti.com>
* Keerthy <j-keerthy@ti.com> [180516 05:43]:
> This adds a pair of context save/restore functions to save/restore the
> state of a set of pinctrl registers. This simplifies some of the AM33XX
> PM code as some of the pinctrl registers are lost when the per power
> domain loses power. The pincrtl code can perform the necessary
> save/restore.
>
> This will also be necessary for hibernation and RTC only sleep, as all
> pinctrl registers all lost.
I think for now you can get away with just adding suspend and resume
calls where suspend calls pdata->context_may_be_lost() and saves
context as needed. And you do want to still call context_may_be_lost()
as Android configured kernel does suspend and resume constantly..
Then the cpu_notifier() can be added later on as needed once the
cpuidle patches are ready.
Regards,
Tony
prev parent reply other threads:[~2018-05-16 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 5:40 [PATCH 0/2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl contex Keerthy
2018-05-16 5:40 ` [PATCH 1/2] arm: mach-omap2: pdata-quirks: Add a quirk function to convey off mode state Keerthy
2018-05-16 14:36 ` Tony Lindgren
2018-05-16 5:40 ` [PATCH 2/2] pinctrl: pinctrl-single: Add functions to save and restore pinctrl context Keerthy
2018-05-16 15:22 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516152241.GF98604@atomide.com \
--to=tony@atomide.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).