From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
Date: Tue, 22 May 2018 13:44:34 -0700 [thread overview]
Message-ID: <20180522204434.GB123708@dtor-ws> (raw)
In-Reply-To: <1511898445.25007.470.camel@linux.intel.com>
On Tue, Nov 28, 2017 at 09:47:25PM +0200, Andy Shevchenko wrote:
> On Tue, 2017-11-28 at 11:46 -0800, Dmitry Torokhov wrote:
> > On Tue, Nov 28, 2017 at 09:29:47PM +0200, Mika Westerberg wrote:
> > > On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> > > > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > > > virtual interrupt numbers for keyboard/touchpa/touchscreen
> > > > controllers
> > > > in ACPI tables, they will also update BIOS version number from 1.0
> > > > to 1.1. Let's limit the DMI quirks that try to preserve virtual
> > > > IRQ
> > > > numbers on Strago boards to those that still carry BIOSes 1.0.
> > > >
> > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > >
> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > >
> > > Assuming there is no version "0.9" or so having the same issue.
> >
> > No, as far as I can tell they all had the default 1.0...
>
> Thanks for fixing that eventually!
Ugh, so this is broken, as 1.0 is BOARD version and not BIOS. Bios
version is in form of Google_BUILD.BRANCH.PATCH, so we can't really use
it to limit the workaround (as we do not have "less than" comparator).
Anyway, in coreboot we changed board version to 1.1, so we should use
it. I'll post v2. Luckily this patch has not been picked by Linus as far
as I can tell.
--
Dmitry
next prev parent reply other threads:[~2018-05-22 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 19:14 [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0 Dmitry Torokhov
2017-11-28 19:29 ` Mika Westerberg
2017-11-28 19:46 ` Dmitry Torokhov
2017-11-28 19:47 ` Andy Shevchenko
2018-05-22 20:44 ` Dmitry Torokhov [this message]
2017-11-28 21:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522204434.GB123708@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).