* [PATCH] pci: qcom: include gpio/consumer.h
@ 2018-05-30 21:53 Arnd Bergmann
2018-06-04 1:24 ` Bjorn Andersson
2018-06-04 17:45 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-05-30 21:53 UTC (permalink / raw)
To: Stanimir Varbanov, Lorenzo Pieralisi, Bjorn Helgaas
Cc: linux-gpio, Arnd Bergmann, Jingoo Han, Srinivas Kandagatla,
Bjorn Andersson, linux-pci, linux-arm-msm, linux-kernel
When CONFIG_GPIOLIB is disabled, we run into a build failure:
drivers/pci/dwc/pcie-qcom.c: In function 'qcom_pcie_probe':
drivers/pci/dwc/pcie-qcom.c:1223:16: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_LOW);
Including gpio/consumer.h directly is the correct fix.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/dwc/pcie-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index b65bbf7c284e..17df19db851e 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -10,7 +10,7 @@
#include <linux/clk.h>
#include <linux/delay.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/iopoll.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: qcom: include gpio/consumer.h
2018-05-30 21:53 [PATCH] pci: qcom: include gpio/consumer.h Arnd Bergmann
@ 2018-06-04 1:24 ` Bjorn Andersson
2018-06-04 17:45 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2018-06-04 1:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stanimir Varbanov, Lorenzo Pieralisi, Bjorn Helgaas, linux-gpio,
Jingoo Han, Srinivas Kandagatla, linux-pci, linux-arm-msm,
linux-kernel
On Wed 30 May 14:53 PDT 2018, Arnd Bergmann wrote:
> When CONFIG_GPIOLIB is disabled, we run into a build failure:
>
> drivers/pci/dwc/pcie-qcom.c: In function 'qcom_pcie_probe':
> drivers/pci/dwc/pcie-qcom.c:1223:16: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
> pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_LOW);
>
> Including gpio/consumer.h directly is the correct fix.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pci/dwc/pcie-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index b65bbf7c284e..17df19db851e 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -10,7 +10,7 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: qcom: include gpio/consumer.h
2018-05-30 21:53 [PATCH] pci: qcom: include gpio/consumer.h Arnd Bergmann
2018-06-04 1:24 ` Bjorn Andersson
@ 2018-06-04 17:45 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2018-06-04 17:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stanimir Varbanov, Lorenzo Pieralisi, Bjorn Helgaas, linux-gpio,
Jingoo Han, Srinivas Kandagatla, Bjorn Andersson, linux-pci,
linux-arm-msm, linux-kernel
On Wed, May 30, 2018 at 11:53:06PM +0200, Arnd Bergmann wrote:
> When CONFIG_GPIOLIB is disabled, we run into a build failure:
>
> drivers/pci/dwc/pcie-qcom.c: In function 'qcom_pcie_probe':
> drivers/pci/dwc/pcie-qcom.c:1223:16: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
> pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_LOW);
>
> Including gpio/consumer.h directly is the correct fix.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied with the other Bjorn's reviewed-by to pci/host/qcom for v4.18,
thanks!
> ---
> drivers/pci/dwc/pcie-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index b65bbf7c284e..17df19db851e 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -10,7 +10,7 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-04 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 21:53 [PATCH] pci: qcom: include gpio/consumer.h Arnd Bergmann
2018-06-04 1:24 ` Bjorn Andersson
2018-06-04 17:45 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).