From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [Letux-kernel] BUG: drivers/pinctrl/core: races in pinctrl_groups and deferred probing Date: Mon, 18 Jun 2018 04:51:22 -0700 Message-ID: <20180618115122.GT26255@atomide.com> References: <20180615065810.GI112168@atomide.com> <20180615111318.GJ112168@atomide.com> <029F115C-480E-485A-B547-9D5873925CEF@goldelico.com> <4DE2E482-B0D3-4799-9E2D-74E2180B305B@goldelico.com> <20180618091433.GP112168@atomide.com> <20180618095428.GQ112168@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Christ van Willegen Cc: Discussions about the Letux Kernel , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Andy Shevchenko , kernel@pyra-handheld.com List-Id: linux-gpio@vger.kernel.org * Christ van Willegen [180618 10:01]: > > --- a/drivers/pinctrl/core.c > > +++ b/drivers/pinctrl/core.c > > + if (!strcmp(function, gname)) > > > This could never fail? gname guaranteed to never == NULL? Thanks I'll add checks to make sure we always have a valid name for new functions and groups added. Regards, Tony