* [PATCH linux-next] gpio: fix meaningless return expression
@ 2018-07-24 11:57 zhong jiang
2018-07-26 8:42 ` Alban
2018-07-29 21:35 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2018-07-24 11:57 UTC (permalink / raw)
To: albeu, linus.walleij; +Cc: linux-gpio, linux-kernel
Fix the following sparse error:
drivers/gpio/gpio-ath79.c:54:16: error: return expression in void function
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/gpio/gpio-ath79.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 684e9d6..0a553d6 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -51,7 +51,7 @@ static u32 ath79_gpio_read(struct ath79_gpio_ctrl *ctrl, unsigned reg)
static void ath79_gpio_write(struct ath79_gpio_ctrl *ctrl,
unsigned reg, u32 val)
{
- return writel(val, ctrl->base + reg);
+ writel(val, ctrl->base + reg);
}
static bool ath79_gpio_update_bits(
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] gpio: fix meaningless return expression
2018-07-24 11:57 [PATCH linux-next] gpio: fix meaningless return expression zhong jiang
@ 2018-07-26 8:42 ` Alban
2018-07-29 21:35 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alban @ 2018-07-26 8:42 UTC (permalink / raw)
To: zhong jiang; +Cc: linus.walleij, linux-gpio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
On Tue, 24 Jul 2018 19:57:43 +0800
zhong jiang <zhongjiang@huawei.com> wrote:
> Fix the following sparse error:
>
> drivers/gpio/gpio-ath79.c:54:16: error: return expression in void
> function
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Alban Bedel <albeu@free.fr>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] gpio: fix meaningless return expression
2018-07-24 11:57 [PATCH linux-next] gpio: fix meaningless return expression zhong jiang
2018-07-26 8:42 ` Alban
@ 2018-07-29 21:35 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-07-29 21:35 UTC (permalink / raw)
To: zhongjiang
Cc: Alban Bedel, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org
On Tue, Jul 24, 2018 at 2:09 PM zhong jiang <zhongjiang@huawei.com> wrote:
> Fix the following sparse error:
>
> drivers/gpio/gpio-ath79.c:54:16: error: return expression in void function
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Patch applied with Alban's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-29 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 11:57 [PATCH linux-next] gpio: fix meaningless return expression zhong jiang
2018-07-26 8:42 ` Alban
2018-07-29 21:35 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).