From: Andrew Lunn <andrew@lunn.ch>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Aditya Prayoga <aditya@kobol.io>,
linux-gpio@vger.kernel.org,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Gauthier Provost <gauthier@kobol.io>,
Alban Browaeys <alban.browaeys@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dennis Gilmore <dennis@ausil.us>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>
Subject: Re: [PATCH RESEND 2/2] gpio: mvebu: Allow to use non-default PWM counter
Date: Thu, 9 Aug 2018 17:43:05 +0200 [thread overview]
Message-ID: <20180809154305.GE20006@lunn.ch> (raw)
In-Reply-To: <9d12abba-0be8-bce7-45d5-99659cbe0915@sorico.fr>
> I'm not sure that the logic:
> 1. Default counter assigned to the bank
> 2. Unused counter that is assigned to other bank
> 3. Fallback to default counter
> is the best one.
Hi Richard
It it totally broken, as you point out. That is why i said it needs to
be limited to two PWMs.
> IMHO, I would either:
> - allow only 2 pwm and no more (but that's a pity)
> - allow lots of fans, but once 2 different speeds are set, return
> EINVAL for another different speed (even if it's on another bank)
This second option also breaks the Linux PWM model.
What you should be thinking about is extending the Linux PWM model so
that one PWM can drive more than one pin.
Andrew
prev parent reply other threads:[~2018-08-09 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 2:29 [PATCH RESEND 0/2] gpio: mvebu: Add support for multiple PWM lines Aditya Prayoga
2018-08-06 2:29 ` [PATCH RESEND 1/2] gpio: mvebu: Add support for multiple PWM lines per GPIO chip Aditya Prayoga
2018-08-06 3:38 ` Andrew Lunn
2018-08-08 10:27 ` Aditya Prayoga
2018-08-29 7:54 ` Linus Walleij
2018-08-29 8:02 ` Thomas Petazzoni
2018-08-29 12:09 ` Linus Walleij
2018-08-29 12:52 ` Andrew Lunn
2018-08-29 8:13 ` Gregory CLEMENT
2018-08-06 2:29 ` [PATCH RESEND 2/2] gpio: mvebu: Allow to use non-default PWM counter Aditya Prayoga
2018-08-06 13:52 ` Andrew Lunn
2018-08-08 11:40 ` Aditya Prayoga
2018-08-09 15:03 ` Richard Genoud
2018-08-09 15:43 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809154305.GE20006@lunn.ch \
--to=andrew@lunn.ch \
--cc=aditya@kobol.io \
--cc=alban.browaeys@gmail.com \
--cc=dennis@ausil.us \
--cc=gauthier@kobol.io \
--cc=gregory.clement@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ralph.sennhauser@gmail.com \
--cc=richard.genoud@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).