From: Tony Lindgren <tony@atomide.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tero Kristo <t-kristo@ti.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead
Date: Tue, 11 Sep 2018 16:28:05 -0700 [thread overview]
Message-ID: <20180911232805.GE5662@atomide.com> (raw)
In-Reply-To: <20180911194035.GA2180@lenoch>
* Ladislav Michl <ladis@linux-mips.org> [180911 19:44]:
> Tony,
>
> On Tue, Sep 11, 2018 at 11:37:29AM -0700, Tony Lindgren wrote:
> > For a long time the gpio-omap custom PM calls have been annoying me so
> > let's replace them with cpu_pm instead. This will enable GPIO PM for
> > deeper idle states on omap4. And we can handle GPIO PM for omap2/3/4
> > in the same way.
> >
> > Note that with this patch we are also slightly changing GPIO PM to be
> > less aggressive for omap3 and only will idle GPIO when PER context
> > may be lost.
>
> I do not think it will make things any worse, but will run my favorite
> latency on test on this patch :)
Thanks I was hoping you'd do that :)
> Meanwhile see nit bellow.
> > + switch (cmd) {
> > + case CPU_CLUSTER_PM_ENTER:
> > + /* Gets cleard on runtime_suspend */
>
> "Gets cleared" perhaps...
Thanks will fix and post v2 after waiting few days for
comments.
Regards,
Tony
next prev parent reply other threads:[~2018-09-11 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 18:37 [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead Tony Lindgren
2018-09-11 19:40 ` Ladislav Michl
2018-09-11 23:28 ` Tony Lindgren [this message]
2018-09-11 23:34 ` Tony Lindgren
2018-09-12 0:29 ` Grygorii Strashko
2018-09-12 0:41 ` Tony Lindgren
2018-09-14 9:09 ` Linus Walleij
2018-09-14 13:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911232805.GE5662@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=ladis@linux-mips.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).