From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Ladislav Michl <ladis@linux-mips.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tero Kristo <t-kristo@ti.com>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead
Date: Tue, 11 Sep 2018 17:41:02 -0700 [thread overview]
Message-ID: <20180912004102.GG5662@atomide.com> (raw)
In-Reply-To: <01f5b04a-82ed-fafe-5b90-3e662f21d0db@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [180912 00:33]:
> On 09/11/2018 01:37 PM, Tony Lindgren wrote:
> > + switch (cmd) {
> > + case CPU_CLUSTER_PM_ENTER:
> > + /* Gets cleard on runtime_suspend */
> > + bank->power_mode = OFF_MODE;
>
> It has to be reset somewhere.
Oh good catch omap_gpio_runtime_suspend() only clears it
if (bank->power_mode != OFF_MODE).. This would certainly
introduce some unexpected latencies..
We can just clear it unconditionally at the end of
CPU_CLUSTER_PM_ENTER handler now.
Regards,
Tony
next prev parent reply other threads:[~2018-09-12 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 18:37 [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead Tony Lindgren
2018-09-11 19:40 ` Ladislav Michl
2018-09-11 23:28 ` Tony Lindgren
2018-09-11 23:34 ` Tony Lindgren
2018-09-12 0:29 ` Grygorii Strashko
2018-09-12 0:41 ` Tony Lindgren [this message]
2018-09-14 9:09 ` Linus Walleij
2018-09-14 13:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912004102.GG5662@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=ladis@linux-mips.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).