From: Rajat Jain <rajatja@google.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: rajatxjain@gmail.com, subrata.banik@intel.com,
aamir.bohra@intel.com, Rajat Jain <rajatja@google.com>
Subject: [PATCH] pinctrl: icelake: Fix the resource number for community-4/5
Date: Thu, 13 Sep 2018 15:31:43 -0700 [thread overview]
Message-ID: <20180913223143.12664-1-rajatja@google.com> (raw)
The Icelake does not have a community-3, and the memory resources are
laid out in the following order in the ACPI:
resource-0: community-0 registers
resource-1: community-1 registers
resource-2: community-2 registers
resource-3: community-4 registers
resource-4: community-5 registers
(EDS also describes the communities in the above order).
Since the pinctrl driver exposes communities 0, 1, 4, 5, it needs to get
the corresponding community registers by getting the resourse number right.
Currently the resourse number is not correct for community 4 and 5, thus
fix that.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
drivers/pinctrl/intel/pinctrl-icelake.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-icelake.c b/drivers/pinctrl/intel/pinctrl-icelake.c
index 630b966ce081..5b4eaf7c90df 100644
--- a/drivers/pinctrl/intel/pinctrl-icelake.c
+++ b/drivers/pinctrl/intel/pinctrl-icelake.c
@@ -331,8 +331,8 @@ static const struct intel_padgroup icllp_community5_gpps[] = {
static const struct intel_community icllp_communities[] = {
ICL_COMMUNITY(0, 0, 58, icllp_community0_gpps),
ICL_COMMUNITY(1, 59, 152, icllp_community1_gpps),
- ICL_COMMUNITY(2, 153, 215, icllp_community4_gpps),
- ICL_COMMUNITY(3, 216, 240, icllp_community5_gpps),
+ ICL_COMMUNITY(3, 153, 215, icllp_community4_gpps),
+ ICL_COMMUNITY(4, 216, 240, icllp_community5_gpps),
};
static const unsigned int icllp_spi0_pins[] = { 22, 23, 24, 25, 26 };
--
2.19.0.397.gdd90340f6a-goog
next reply other threads:[~2018-09-13 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 22:31 Rajat Jain [this message]
2018-09-14 7:33 ` [PATCH] pinctrl: icelake: Fix the resource number for community-4/5 Andy Shevchenko
2018-09-14 21:06 ` Rajat Jain
2018-09-14 21:38 ` Rajat Jain
2018-09-20 17:19 ` Rajat Jain
2018-09-24 13:59 ` Andy Shevchenko
2018-09-24 14:50 ` Banik, Subrata
2018-09-24 17:04 ` Rajat Jain
2018-09-24 21:09 ` Andy Shevchenko
2018-09-24 21:31 ` Rajat Jain
2018-09-25 8:31 ` Andy Shevchenko
2018-09-24 21:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913223143.12664-1-rajatja@google.com \
--to=rajatja@google.com \
--cc=aamir.bohra@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rajatxjain@gmail.com \
--cc=subrata.banik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).