* [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E
@ 2018-09-15 21:15 Simon Detheridge
2018-09-17 8:19 ` Mika Westerberg
2018-09-18 23:34 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Simon Detheridge @ 2018-09-15 21:15 UTC (permalink / raw)
Cc: Simon Detheridge, Mika Westerberg, Andy Shevchenko, Linus Walleij,
linux-gpio, linux-kernel
The gpio base for GPP-E was set incorrectly to 258 instead of 256,
preventing the touchpad working on my Tong Fang GK5CN5Z laptop.
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=200787
Signed-off-by: Simon Detheridge <s@sd.ai>
---
drivers/pinctrl/intel/pinctrl-cannonlake.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cannonlake.c b/drivers/pinctrl/intel/pinctrl-cannonlake.c
index fb1afe55bf53..8d48371caaa2 100644
--- a/drivers/pinctrl/intel/pinctrl-cannonlake.c
+++ b/drivers/pinctrl/intel/pinctrl-cannonlake.c
@@ -379,7 +379,7 @@ static const struct intel_padgroup cnlh_community1_gpps[] = {
static const struct intel_padgroup cnlh_community3_gpps[] = {
CNL_GPP(0, 155, 178, 192), /* GPP_K */
CNL_GPP(1, 179, 202, 224), /* GPP_H */
- CNL_GPP(2, 203, 215, 258), /* GPP_E */
+ CNL_GPP(2, 203, 215, 256), /* GPP_E */
CNL_GPP(3, 216, 239, 288), /* GPP_F */
CNL_GPP(4, 240, 248, CNL_NO_GPIO), /* SPI */
};
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E
2018-09-15 21:15 [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E Simon Detheridge
@ 2018-09-17 8:19 ` Mika Westerberg
2018-09-18 23:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2018-09-17 8:19 UTC (permalink / raw)
To: Simon Detheridge; +Cc: Andy Shevchenko, Linus Walleij, linux-gpio, linux-kernel
On Sat, Sep 15, 2018 at 10:15:18PM +0100, Simon Detheridge wrote:
> The gpio base for GPP-E was set incorrectly to 258 instead of 256,
> preventing the touchpad working on my Tong Fang GK5CN5Z laptop.
>
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=200787
> Signed-off-by: Simon Detheridge <s@sd.ai>
Indeed, you are correct.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E
2018-09-15 21:15 [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E Simon Detheridge
2018-09-17 8:19 ` Mika Westerberg
@ 2018-09-18 23:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-09-18 23:34 UTC (permalink / raw)
To: s
Cc: Mika Westerberg, Andy Shevchenko, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org
On Sat, Sep 15, 2018 at 2:16 PM Simon Detheridge <s@sd.ai> wrote:
> The gpio base for GPP-E was set incorrectly to 258 instead of 256,
> preventing the touchpad working on my Tong Fang GK5CN5Z laptop.
>
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=200787
> Signed-off-by: Simon Detheridge <s@sd.ai>
Patch applied for fixes.
It seems I should tag it for stable too.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-18 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-15 21:15 [PATCH] pinctrl: cannonlake: Fix gpio base for GPP-E Simon Detheridge
2018-09-17 8:19 ` Mika Westerberg
2018-09-18 23:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).