* [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support
@ 2018-09-20 1:47 Bjorn Andersson
2018-09-20 1:56 ` Bjorn Andersson
2018-09-20 15:30 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-20 1:47 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Mark Rutland
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
From: Vinod Koul <vkoul@kernel.org>
Update the binding and driver for pms405-gpios
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index ffd4345415f3..ab4000eab07d 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -19,6 +19,7 @@ PMIC's from Qualcomm.
"qcom,pm8998-gpio"
"qcom,pma8084-gpio"
"qcom,pmi8994-gpio"
+ "qcom,pms405-gpio"
And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
if the device is on an spmi bus or an ssbi bus respectively
@@ -91,6 +92,7 @@ to specify in a pin configuration subnode:
gpio1-gpio26 for pm8998
gpio1-gpio22 for pma8084
gpio1-gpio10 for pmi8994
+ gpio1-gpio11 for pms405
- function:
Usage: required
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index a29efbe08f48..b54891998caa 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
{ .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
{ .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
+ { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
{ .compatible = "qcom,spmi-gpio" }, /* Generic */
{ },
};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support
2018-09-20 1:47 [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support Bjorn Andersson
@ 2018-09-20 1:56 ` Bjorn Andersson
2018-09-20 15:30 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-20 1:56 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Mark Rutland
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Wed 19 Sep 18:47 PDT 2018, Bjorn Andersson wrote:
> From: Vinod Koul <vkoul@kernel.org>
>
> Update the binding and driver for pms405-gpios
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index ffd4345415f3..ab4000eab07d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -19,6 +19,7 @@ PMIC's from Qualcomm.
> "qcom,pm8998-gpio"
> "qcom,pma8084-gpio"
> "qcom,pmi8994-gpio"
> + "qcom,pms405-gpio"
>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> if the device is on an spmi bus or an ssbi bus respectively
> @@ -91,6 +92,7 @@ to specify in a pin configuration subnode:
> gpio1-gpio26 for pm8998
> gpio1-gpio22 for pma8084
> gpio1-gpio10 for pmi8994
> + gpio1-gpio11 for pms405
>
> - function:
> Usage: required
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index a29efbe08f48..b54891998caa 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
> { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
> { .compatible = "qcom,spmi-gpio" }, /* Generic */
> { },
> };
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support
2018-09-20 1:47 [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support Bjorn Andersson
2018-09-20 1:56 ` Bjorn Andersson
@ 2018-09-20 15:30 ` Stephen Boyd
2018-09-20 16:34 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2018-09-20 15:30 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Mark Rutland, Rob Herring
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
Quoting Bjorn Andersson (2018-09-19 18:47:05)
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index a29efbe08f48..b54891998caa 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
> { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
I thought we didn't update the C driver, because there isn't anything to
do here. Just make binding updates and it's all fine.
> { .compatible = "qcom,spmi-gpio" }, /* Generic */
> { },
> };
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support
2018-09-20 15:30 ` Stephen Boyd
@ 2018-09-20 16:34 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-20 16:34 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, Mark Rutland, Rob Herring, linux-arm-msm,
linux-gpio, devicetree, linux-kernel
On Thu 20 Sep 08:30 PDT 2018, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2018-09-19 18:47:05)
> > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > index a29efbe08f48..b54891998caa 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> > { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
> > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> > + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
>
> I thought we didn't update the C driver, because there isn't anything to
> do here. Just make binding updates and it's all fine.
>
Right, forgot that we just use the fallback.
Thanks,
Bjorn
> > { .compatible = "qcom,spmi-gpio" }, /* Generic */
> > { },
> > };
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-20 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 1:47 [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support Bjorn Andersson
2018-09-20 1:56 ` Bjorn Andersson
2018-09-20 15:30 ` Stephen Boyd
2018-09-20 16:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).