From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support
Date: Thu, 20 Sep 2018 09:34:05 -0700 [thread overview]
Message-ID: <20180920163405.GE1367@tuxbook-pro> (raw)
In-Reply-To: <153745740342.119890.12073424910838960020@swboyd.mtv.corp.google.com>
On Thu 20 Sep 08:30 PDT 2018, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2018-09-19 18:47:05)
> > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > index a29efbe08f48..b54891998caa 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> > { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> > { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
> > { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> > + { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
>
> I thought we didn't update the C driver, because there isn't anything to
> do here. Just make binding updates and it's all fine.
>
Right, forgot that we just use the fallback.
Thanks,
Bjorn
> > { .compatible = "qcom,spmi-gpio" }, /* Generic */
> > { },
> > };
prev parent reply other threads:[~2018-09-20 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 1:47 [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support Bjorn Andersson
2018-09-20 1:56 ` Bjorn Andersson
2018-09-20 15:30 ` Stephen Boyd
2018-09-20 16:34 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920163405.GE1367@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).