From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v2] pinctrl: madera: Fix uninitialized variable bug in madera_mux_set_mux Date: Wed, 10 Oct 2018 17:08:01 +0100 Message-ID: <20181010160801.GB1653@imbe.wolfsonmicro.main> References: <20181010151313.GA16854@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181010151313.GA16854@embeddedor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Gustavo A. R. Silva" Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Richard Fitzgerald List-Id: linux-gpio@vger.kernel.org On Wed, Oct 10, 2018 at 05:13:13PM +0200, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *ret* is checked > in an IF statement, and then its value is used to report an error at > line 659 without being properly initialized previously: > > 659 if (ret) > 660 dev_err(priv->dev, "Failed to write to 0x%x (%d)\n", reg, ret); > > Fix this by initializing variable *ret* to 0 in order to > avoid unpredictable or unintended results. > > Addresses-Coverity-ID: 1471969 ("Uninitialized scalar variable") > Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera codecs") > Signed-off-by: Gustavo A. R. Silva > --- Acked-by: Charles Keepax Thanks, Charles