* [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2
@ 2018-09-17 11:17 Lubomir Rintel
2018-11-03 19:03 ` Pavel Machek
0 siblings, 1 reply; 6+ messages in thread
From: Lubomir Rintel @ 2018-09-17 11:17 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-gpio, Lubomir Rintel, Robert Jarzmik, Linus Walleij
Similarly to PXA3xx pinctrl-single can't set pin direction on MMP2 either.
See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
PXA3xx")
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/gpio/gpio-pxa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index c18712dabf93..2f8fade7497d 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -245,6 +245,7 @@ static bool pxa_gpio_has_pinctrl(void)
{
switch (gpio_type) {
case PXA3XX_GPIO:
+ case MMP2_GPIO:
return false;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2
@ 2019-02-13 23:06 Lubomir Rintel
2019-02-14 8:13 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Lubomir Rintel @ 2019-02-13 23:06 UTC (permalink / raw)
To: Robert Jarzmik
Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel,
Lubomir Rintel, Pavel Machek
Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
PXA3xx")
Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
drivers/gpio/gpio-pxa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index e9600b556f39..bcc6be4a5cb2 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -245,6 +245,7 @@ static bool pxa_gpio_has_pinctrl(void)
{
switch (gpio_type) {
case PXA3XX_GPIO:
+ case MMP2_GPIO:
return false;
default:
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2
2019-02-13 23:06 Lubomir Rintel
@ 2019-02-14 8:13 ` Linus Walleij
2019-02-14 8:52 ` Lubomir Rintel
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2019-02-14 8:13 UTC (permalink / raw)
To: Lubomir Rintel
Cc: Robert Jarzmik, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org, Pavel Machek
On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> PXA3xx")
>
> Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Patch applied for fixes.
Should this even go into stable?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2
2019-02-14 8:13 ` Linus Walleij
@ 2019-02-14 8:52 ` Lubomir Rintel
2019-02-14 9:05 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Lubomir Rintel @ 2019-02-14 8:52 UTC (permalink / raw)
To: Linus Walleij
Cc: Robert Jarzmik, Bartosz Golaszewski, linux-gpio,
linux-kernel@vger.kernel.org, Pavel Machek
On Thu, 2019-02-14 at 09:13 +0100, Linus Walleij wrote:
> On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> > Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> > See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> > PXA3xx")
> >
> > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>
> Patch applied for fixes.
>
> Should this even go into stable?
I would tend to think it should.
This caused a regression for MMP2 platforms that don't use a pinctrl
driver, and none of them do.
On the other hand it went unnoticed since v4.5.
I've seen stable maintainers pick up fixes even when stable@ wasn't
Cc'd. I guess they apply some heuristics and perhaps look at Fixes:
tags to identify bugfixes?
> Yours,
> Linus Walleij
Lubo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2
2019-02-14 8:52 ` Lubomir Rintel
@ 2019-02-14 9:05 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-02-14 9:05 UTC (permalink / raw)
To: Lubomir Rintel
Cc: Robert Jarzmik, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org, Pavel Machek
On Thu, Feb 14, 2019 at 9:52 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> On Thu, 2019-02-14 at 09:13 +0100, Linus Walleij wrote:
> > On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> >
> > > Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> > > See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> > > PXA3xx")
> > >
> > > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> >
> > Patch applied for fixes.
> >
> > Should this even go into stable?
>
> I would tend to think it should.
OK I tag it for stable.
> This caused a regression for MMP2 platforms that don't use a pinctrl
> driver, and none of them do.
>
> On the other hand it went unnoticed since v4.5.
>
> I've seen stable maintainers pick up fixes even when stable@ wasn't
> Cc'd. I guess they apply some heuristics and perhaps look at Fixes:
> tags to identify bugfixes?
Yes Sasha Levin has an some machine-learning AI that looks at patches
to see if they are elegible for stable, and sometimes people tell
Greg directly to pick a patch, and sometimes Greg just picks a patch
he likes.
But to make things easier for the stable maintainers, it's best to CC stable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-14 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-17 11:17 [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2 Lubomir Rintel
2018-11-03 19:03 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2019-02-13 23:06 Lubomir Rintel
2019-02-14 8:13 ` Linus Walleij
2019-02-14 8:52 ` Lubomir Rintel
2019-02-14 9:05 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).