From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP Date: Wed, 7 Nov 2018 09:37:41 -0800 Message-ID: <20181107173741.GL3074@bombadil.infradead.org> References: <1540807618-13246-1-git-send-email-soares@synopsys.com> <1540807618-13246-2-git-send-email-soares@synopsys.com> <20181107170553.GJ3074@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: vitor Cc: boris.brezillon@bootlin.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, psroka@cadence.com, agolec@cadence.com, adouglas@cadence.com, bfolta@cadence.com, dkos@cadence.com, alicja@cadence.com, cwronka@cadence.com, sureshp@cadence.com, rafalc@cadence.com, thomas.petazzoni@bootlin.com, nm@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, linus.walleij@linaro.org, Xiang.Lin@synaptics.com, linux-gpio@vger.kernel.org, nsekhar@ti.com, pgaj@cadence.com, peda@axentia.se, mshettel@codeaurora.org, swboyd@chromium.org, joao.pinto@synopsys.com, luis List-Id: linux-gpio@vger.kernel.org On Wed, Nov 07, 2018 at 05:30:22PM +0000, vitor wrote: > Hi Matthew, > > > On 07/11/18 17:05, Matthew Wilcox wrote: > > On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote: > > > Add driver for Synopsys DesignWare I3C master IP > > The so-called "data sheet" (actually just an advertising brochure) > > The datasheet is there to download. Really? I went to the link in your message, filled out the stupid information box that your company has now decided to start spamming me with, and I got a 2-page brochure telling me how wonderful it was. It's *called* a datasheet. Even right there in its name: dwc_mipi_i3c_ds.pdf It's not a data sheet. > Right now the driver does not support DMA interface which will be added > later as the other missed I3C features. > > What do you suggest to avoid this misunderstanding? A big missing feature like that is probably worth mentioning in a comment. eg: TODO: DMA support.