From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpio: hlwd: Add basic IRQ support
Date: Mon, 14 Jan 2019 19:38:32 +0100 [thread overview]
Message-ID: <20190114183832.GC22334@latitude> (raw)
In-Reply-To: <CACRpkdYyMwu+hFQF4PUSb8N8zo3QEFt5=curhsdTFP1FCtGpNw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
Hi,
On Mon, Jan 14, 2019 at 11:20:49AM +0100, Linus Walleij wrote:
> Hi Jonathan,
>
> thanks for the patch! It is looking very good.
> Some minor comments:
>
> On Sun, Jan 13, 2019 at 3:00 PM Jonathan Neuschäfer
[...]
> > + spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags);
> > + pending = hlwd->gpioc.read_reg(hlwd->regs + HW_GPIOB_INTFLAG);
> > + pending &= hlwd->gpioc.read_reg(hlwd->regs + HW_GPIOB_INTMASK);
>
> Please just access IO directly instead through the helper.
> ioread32be()/iowrite32be() I suppose?
Ok. Yes, 32-bit big endian is correct.
[...]
> > + hlwd->irqc.name = "GPIO";
>
> What about using something device-unique?
>
> hlwd->irqc.name = dev_name(&pdev->dev);
>
> for example?
Good idea, especially considering that the Wii U (the successor of the
Wii) has two of these GPIO controllers.
> otherwise it looks fine!
Cool, I'll send a v2 with these two points addressed.
Thanks,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-14 18:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 13:58 [PATCH 0/2] GPIO: hlwd: Implement IRQ support Jonathan Neuschäfer
2019-01-13 13:58 ` [PATCH 1/2] gpio: hlwd: Add basic " Jonathan Neuschäfer
2019-01-14 10:20 ` Linus Walleij
2019-01-14 18:38 ` Jonathan Neuschäfer [this message]
2019-01-13 13:58 ` [PATCH 2/2] gpio: hlwd: Implement edge trigger emulation Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114183832.GC22334@latitude \
--to=j.neuschaefer@gmx.net \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).