From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Brian Masney <masneyb@onstation.org>
Cc: linus.walleij@linaro.org, sboyd@kernel.org,
andy.gross@linaro.org, marc.zyngier@arm.com, shawnguo@kernel.org,
dianders@chromium.org, linux-gpio@vger.kernel.org,
nicolas.dechesne@linaro.org, niklas.cassel@linaro.org,
david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 08/14] ARM: dts: qcom: pm8941: add interrupt controller properties
Date: Mon, 14 Jan 2019 16:42:41 -0800 [thread overview]
Message-ID: <20190115004240.GL9278@minitux> (raw)
In-Reply-To: <20190113154716.5145-9-masneyb@onstation.org>
On Sun 13 Jan 07:47 PST 2019, Brian Masney wrote:
> Add interrupt controller properties now that spmi-gpio is a proper
> hierarchical IRQ chip. The interrupts property is no longer needed so
> remove it. Code was tested on the LG Nexus 5 (hammerhead) phone.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> ---
> Changes since v3:
> - None
>
> Changes since v2:
> - Remove interrupt-parent property
>
> Changes since v1:
> - Interrupts are now two cells instead of four cells.
> - Drop unnecessary interrupts property.
>
> arch/arm/boot/dts/qcom-pm8941.dtsi | 38 ++----------------------------
> 1 file changed, 2 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 2515c5c217ac..e65049e0fb45 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -64,42 +64,8 @@
> reg = <0xc000>;
> gpio-controller;
> #gpio-cells = <2>;
> - interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> - <0 0xc1 0 IRQ_TYPE_NONE>,
> - <0 0xc2 0 IRQ_TYPE_NONE>,
> - <0 0xc3 0 IRQ_TYPE_NONE>,
> - <0 0xc4 0 IRQ_TYPE_NONE>,
> - <0 0xc5 0 IRQ_TYPE_NONE>,
> - <0 0xc6 0 IRQ_TYPE_NONE>,
> - <0 0xc7 0 IRQ_TYPE_NONE>,
> - <0 0xc8 0 IRQ_TYPE_NONE>,
> - <0 0xc9 0 IRQ_TYPE_NONE>,
> - <0 0xca 0 IRQ_TYPE_NONE>,
> - <0 0xcb 0 IRQ_TYPE_NONE>,
> - <0 0xcc 0 IRQ_TYPE_NONE>,
> - <0 0xcd 0 IRQ_TYPE_NONE>,
> - <0 0xce 0 IRQ_TYPE_NONE>,
> - <0 0xcf 0 IRQ_TYPE_NONE>,
> - <0 0xd0 0 IRQ_TYPE_NONE>,
> - <0 0xd1 0 IRQ_TYPE_NONE>,
> - <0 0xd2 0 IRQ_TYPE_NONE>,
> - <0 0xd3 0 IRQ_TYPE_NONE>,
> - <0 0xd4 0 IRQ_TYPE_NONE>,
> - <0 0xd5 0 IRQ_TYPE_NONE>,
> - <0 0xd6 0 IRQ_TYPE_NONE>,
> - <0 0xd7 0 IRQ_TYPE_NONE>,
> - <0 0xd8 0 IRQ_TYPE_NONE>,
> - <0 0xd9 0 IRQ_TYPE_NONE>,
> - <0 0xda 0 IRQ_TYPE_NONE>,
> - <0 0xdb 0 IRQ_TYPE_NONE>,
> - <0 0xdc 0 IRQ_TYPE_NONE>,
> - <0 0xdd 0 IRQ_TYPE_NONE>,
> - <0 0xde 0 IRQ_TYPE_NONE>,
> - <0 0xdf 0 IRQ_TYPE_NONE>,
> - <0 0xe0 0 IRQ_TYPE_NONE>,
> - <0 0xe1 0 IRQ_TYPE_NONE>,
> - <0 0xe2 0 IRQ_TYPE_NONE>,
> - <0 0xe3 0 IRQ_TYPE_NONE>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
>
> boost_bypass_n_pin: boost-bypass {
> pins = "gpio21";
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-01-15 0:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 15:47 [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 01/14] dt-bindings: pinctrl: qcom-pmic-gpio: add qcom,pmi8998-gpio binding Brian Masney
2019-01-14 23:42 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-15 20:07 ` Rob Herring
2019-01-13 15:47 ` [PATCH v4 02/14] pinctrl: qcom: spmi-gpio: add support for three new variants Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 03/14] pinctrl: qcom: spmi-gpio: hardcode IRQ counts Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:34 ` Bjorn Andersson
2019-01-15 1:14 ` Brian Masney
2019-01-15 1:24 ` Brian Masney
2019-01-13 15:47 ` [PATCH v4 04/14] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-13 15:47 ` [PATCH v4 05/14] gpio: add irq domain activate/deactivate functions Brian Masney
2019-01-13 15:47 ` [PATCH v4 06/14] spmi: pmic-arb: disassociate old virq if hwirq mapping already exists Brian Masney
2019-01-14 23:50 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 08/14] ARM: dts: qcom: pm8941: add interrupt controller properties Brian Masney
2019-01-15 0:42 ` Bjorn Andersson [this message]
2019-01-13 15:47 ` [PATCH v4 09/14] ARM: dts: qcom: pma8084: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 10/14] arm64: dts: qcom: pm8005: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 11/14] arm64: dts: qcom: pm8998: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 12/14] arm64: dts: qcom: pmi8994: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 13/14] arm64: dts: qcom: pmi8998: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 14/14] spmi: pmic-arb: revert "disassociate old virq if hwirq mapping already exists" Brian Masney
2019-01-14 8:43 ` [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Linus Walleij
2019-01-14 8:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115004240.GL9278@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).