* [PATCH v3 1/2] gpio: altera-a10sr: Set proper output level for direction_output
@ 2019-01-23 0:00 Axel Lin
2019-01-23 16:16 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2019-01-23 0:00 UTC (permalink / raw)
To: Linus Walleij
Cc: Thor Thayer, Bartosz Golaszewski, linux-gpio, Axel Lin, stable
The altr_a10sr_gpio_direction_output should set proper output level
based on the value argument.
Fixes: 26a48c4cc2f1 ("gpio: altera-a10sr: Add A10 System Resource Chip GPIO support.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Tested by: Thor Thayer <thor.thayer@linux.intel.com>
Reviewed by: Thor Thayer <thor.thayer@linux.intel.com>
---
v3: Add Fixes tag and cc stable
v2: Based on Bartosz's comment to split the patch.
1/2 is bug fix
2/2 is coding style fix and fix checkpatch warning
drivers/gpio/gpio-altera-a10sr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
index 6b11f1314248..7f9e0304b510 100644
--- a/drivers/gpio/gpio-altera-a10sr.c
+++ b/drivers/gpio/gpio-altera-a10sr.c
@@ -66,8 +66,10 @@ static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
unsigned int nr, int value)
{
- if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
+ if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {
+ altr_a10sr_gpio_set(gc, nr, value);
return 0;
+ }
return -EINVAL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 1/2] gpio: altera-a10sr: Set proper output level for direction_output
2019-01-23 0:00 [PATCH v3 1/2] gpio: altera-a10sr: Set proper output level for direction_output Axel Lin
@ 2019-01-23 16:16 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-01-23 16:16 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Thor Thayer, linux-gpio, Stable # 4 . 20+
śr., 23 sty 2019 o 01:01 Axel Lin <axel.lin@ingics.com> napisał(a):
>
> The altr_a10sr_gpio_direction_output should set proper output level
> based on the value argument.
>
> Fixes: 26a48c4cc2f1 ("gpio: altera-a10sr: Add A10 System Resource Chip GPIO support.")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Tested by: Thor Thayer <thor.thayer@linux.intel.com>
> Reviewed by: Thor Thayer <thor.thayer@linux.intel.com>
> ---
> v3: Add Fixes tag and cc stable
> v2: Based on Bartosz's comment to split the patch.
> 1/2 is bug fix
> 2/2 is coding style fix and fix checkpatch warning
> drivers/gpio/gpio-altera-a10sr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
> index 6b11f1314248..7f9e0304b510 100644
> --- a/drivers/gpio/gpio-altera-a10sr.c
> +++ b/drivers/gpio/gpio-altera-a10sr.c
> @@ -66,8 +66,10 @@ static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
> static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
> unsigned int nr, int value)
> {
> - if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
> + if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {
> + altr_a10sr_gpio_set(gc, nr, value);
> return 0;
> + }
> return -EINVAL;
> }
>
> --
> 2.17.1
>
Both applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-23 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-23 0:00 [PATCH v3 1/2] gpio: altera-a10sr: Set proper output level for direction_output Axel Lin
2019-01-23 16:16 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).