* [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
@ 2019-01-28 22:35 Dmitry Voytik
2019-01-29 5:02 ` Sean Wang
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Voytik @ 2019-01-28 22:35 UTC (permalink / raw)
To: Linus Walleij, Sean Wang
Cc: Matthias Brugger, Ryder Lee, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, Dmitry Voytik
How to reproduce the problem:
$ make tinyconfig
$ make menuconfig
then enable:
CONFIG_COMPILE_TEST=y
CONFIG_PINCTRL=y
and any of these:
CONFIG_PINCTRL_MT7622=y
CONFIG_PINCTRL_MT7629=y
CONFIG_PINCTRL_MT7623=y
This combination causes build failure.
Fix the problem by making PINCTRL_MT76XX to depend on CONFIG_OF=y.
Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
---
drivers/pinctrl/mediatek/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index 1817786ab6aa..a005cbccb4f7 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -45,12 +45,14 @@ config PINCTRL_MT2701
config PINCTRL_MT7623
bool "Mediatek MT7623 pin control with generic binding"
depends on MACH_MT7623 || COMPILE_TEST
+ depends on OF
default MACH_MT7623
select PINCTRL_MTK_MOORE
config PINCTRL_MT7629
bool "Mediatek MT7629 pin control"
depends on MACH_MT7629 || COMPILE_TEST
+ depends on OF
default MACH_MT7629
select PINCTRL_MTK_MOORE
@@ -92,6 +94,7 @@ config PINCTRL_MT6797
config PINCTRL_MT7622
bool "MediaTek MT7622 pin control"
+ depends on OF
depends on ARM64 || COMPILE_TEST
default ARM64 && ARCH_MEDIATEK
select PINCTRL_MTK_MOORE
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
2019-01-28 22:35 [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX Dmitry Voytik
@ 2019-01-29 5:02 ` Sean Wang
2019-01-29 6:22 ` Dmitry Voytik
0 siblings, 1 reply; 3+ messages in thread
From: Sean Wang @ 2019-01-29 5:02 UTC (permalink / raw)
To: Dmitry Voytik
Cc: Linus Walleij, Matthias Brugger, Ryder Lee, linux-mediatek,
linux-gpio, linux-kernel, linux-arm-kernel
On Mon, Jan 28, 2019 at 2:35 PM Dmitry Voytik <voytikd@gmail.com> wrote:
>
> How to reproduce the problem:
> $ make tinyconfig
> $ make menuconfig
> then enable:
> CONFIG_COMPILE_TEST=y
> CONFIG_PINCTRL=y
> and any of these:
> CONFIG_PINCTRL_MT7622=y
> CONFIG_PINCTRL_MT7629=y
> CONFIG_PINCTRL_MT7623=y
>
> This combination causes build failure.
>
> Fix the problem by making PINCTRL_MT76XX to depend on CONFIG_OF=y.
>
> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
> ---
> drivers/pinctrl/mediatek/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 1817786ab6aa..a005cbccb4f7 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -45,12 +45,14 @@ config PINCTRL_MT2701
> config PINCTRL_MT7623
> bool "Mediatek MT7623 pin control with generic binding"
> depends on MACH_MT7623 || COMPILE_TEST
> + depends on OF
> default MACH_MT7623
> select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT7629
> bool "Mediatek MT7629 pin control"
> depends on MACH_MT7629 || COMPILE_TEST
> + depends on OF
> default MACH_MT7629
> select PINCTRL_MTK_MOORE
>
> @@ -92,6 +94,7 @@ config PINCTRL_MT6797
>
> config PINCTRL_MT7622
> bool "MediaTek MT7622 pin control"
> + depends on OF
> depends on ARM64 || COMPILE_TEST
> default ARM64 && ARCH_MEDIATEK
> select PINCTRL_MTK_MOORE
> --
> 2.20.1
>
It seems the commit 2d2d478576d71000b29c52668c5712c825ee9af8 already
fixed the problem or is there something I'm missing?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
2019-01-29 5:02 ` Sean Wang
@ 2019-01-29 6:22 ` Dmitry Voytik
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Voytik @ 2019-01-29 6:22 UTC (permalink / raw)
To: Sean Wang
Cc: Linus Walleij, Matthias Brugger, Ryder Lee, linux-mediatek,
linux-gpio, linux-kernel, linux-arm-kernel
On 1/29/19 6:02 AM, Sean Wang wrote:
> On Mon, Jan 28, 2019 at 2:35 PM Dmitry Voytik <voytikd@gmail.com> wrote:
>>
>> How to reproduce the problem:
>> $ make tinyconfig
>> $ make menuconfig
>> then enable:
>> CONFIG_COMPILE_TEST=y
>> CONFIG_PINCTRL=y
>> and any of these:
>> CONFIG_PINCTRL_MT7622=y
>> CONFIG_PINCTRL_MT7629=y
>> CONFIG_PINCTRL_MT7623=y
>>
>> This combination causes build failure.
>>
>> Fix the problem by making PINCTRL_MT76XX to depend on CONFIG_OF=y.
>>
>> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
>> ---
>> drivers/pinctrl/mediatek/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
>> index 1817786ab6aa..a005cbccb4f7 100644
>> --- a/drivers/pinctrl/mediatek/Kconfig
>> +++ b/drivers/pinctrl/mediatek/Kconfig
>> @@ -45,12 +45,14 @@ config PINCTRL_MT2701
>> config PINCTRL_MT7623
>> bool "Mediatek MT7623 pin control with generic binding"
>> depends on MACH_MT7623 || COMPILE_TEST
>> + depends on OF
>> default MACH_MT7623
>> select PINCTRL_MTK_MOORE
>>
>> config PINCTRL_MT7629
>> bool "Mediatek MT7629 pin control"
>> depends on MACH_MT7629 || COMPILE_TEST
>> + depends on OF
>> default MACH_MT7629
>> select PINCTRL_MTK_MOORE
>>
>> @@ -92,6 +94,7 @@ config PINCTRL_MT6797
>>
>> config PINCTRL_MT7622
>> bool "MediaTek MT7622 pin control"
>> + depends on OF
>> depends on ARM64 || COMPILE_TEST
>> default ARM64 && ARCH_MEDIATEK
>> select PINCTRL_MTK_MOORE
>> --
>> 2.20.1
>>
>
> It seems the commit 2d2d478576d71000b29c52668c5712c825ee9af8 already
> fixed the problem or is there something I'm missing?
>
Opps, sorry. Should have checked linux-pinctrl.git.
Sorry for spamming.
BR,
Dmitry.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-29 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-28 22:35 [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX Dmitry Voytik
2019-01-29 5:02 ` Sean Wang
2019-01-29 6:22 ` Dmitry Voytik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).