From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk
Subject: Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro
Date: Wed, 30 Jan 2019 19:18:14 +0900 [thread overview]
Message-ID: <20190130101814.GA3668@icarus> (raw)
In-Reply-To: <20190129170734.688a6adf91267cc6f1b5fa08@linux-foundation.org>
On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote:
> Do we have any expectation that these facilities will be used by
> anything other than GPIO? If not then perhaps they should be sited
> within drivers/gpio (presumably as a standalone module) until such a
> need is found?
I can move it within drivers/gpio since my only use at moment is for
these gpio drivers I maintain. However, moving it to the gpio subsystem
does make it less likely to be seen by authors in other subsystems who
may have use for it -- so there is the chance that this becomes isolated
and untilized only amonst the gpio drivers. That may not be such a bad
thing in the end; I suspect it will be easy to spot if other subsystems
start implementing their own for_each_set_clump (if other subsystems
would even have such a need for it).
Linus, if I move the for_each_set_clump macro and related functions to
drivers/gpio, should I move the code into the gpiolib.h and gpiolib.c
files? Or would it be best to implement this as a separate standalone
module, and make a Kconfig dependency for those gpio drivers which
require it? A standalone module feels somewhat overkill for such little
code in my opinion.
William Breathitt Gray
next prev parent reply other threads:[~2019-01-30 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:19 [PATCH v8 0/8] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-01-14 6:19 ` [PATCH v8 1/8] bitops: " William Breathitt Gray
2019-01-14 6:20 ` [PATCH v8 2/8] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-01-14 6:20 ` [PATCH v8 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-01-14 6:20 ` [PATCH v8 4/8] gpio: 104-idi-48: " William Breathitt Gray
2019-01-14 6:21 ` [PATCH v8 5/8] gpio: gpio-mm: " William Breathitt Gray
2019-01-14 6:21 ` [PATCH v8 6/8] gpio: ws16c48: " William Breathitt Gray
2019-01-14 6:21 ` [PATCH v8 7/8] gpio: pci-idio-16: " William Breathitt Gray
2019-01-14 6:22 ` [PATCH v8 8/8] gpio: pcie-idio-24: " William Breathitt Gray
2019-01-30 1:07 ` [PATCH v8 0/8] Introduce the " Andrew Morton
2019-01-30 9:44 ` Linus Walleij
2019-01-30 10:18 ` William Breathitt Gray [this message]
2019-01-30 11:56 ` Linus Walleij
2019-02-08 16:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130101814.GA3668@icarus \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).