From: Pavel Machek <pavel@ucw.cz>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5 07/11] power: supply: max77650: add support for battery charger
Date: Thu, 14 Feb 2019 11:39:44 +0100 [thread overview]
Message-ID: <20190214103944.GC6132@amd> (raw)
In-Reply-To: <20190213134335.10838-8-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
Hi!
> +#define MAX77650_CHG_OFF 0x00
> +#define MAX77650_CHG_PREQ 0x01
> +
> +#define MAX77650_CHGIN_UNDERVOLTAGE_LOCKOUT 0x00
> +#define MAX77650_CHGIN_OVERVOLTAGE_LOCKOUT 0x01
> +#define MAX77650_CHGIN_OKAY 0x11
Thanks for doing this.
> +#define MAX77650_CHG_ON_CURR 0x02
> +#define MAX77650_CHG_ON_CURR_JEITA 0x03
> +#define MAX77650_CHG_ON_VOLT 0x04
> +#define MAX77650_CHG_ON_VOLT_JEITA 0x05
> +#define MAX77650_CHG_ON_TOPOFF 0x06
> +#define MAX77650_CHG_ON_TOPOFF_JEITA 0x07
> +#define MAX77650_CHG_DONE 0x08
> +#define MAX77650_CHG_DONE_JEITA 0x09
> +#define MAX77650_CHG_SUSP_PREQ_TIM_FAULT 0x0a
> +#define MAX77650_CHG_SUSP_FAST_CHG_TIM_FAULT 0x0b
> +#define MAX77650_CHG_SUSP_BATT_TEMP_FAULT 0x0c
> +
> +#define MAX77650_CHARGER_CHGIN_DTLS_MASK GENMASK(3, 2)
> +#define MAX77650_CHARGER_CHGIN_DTLS_BITS(_reg) \
> + (((_reg) & MAX77650_CHARGER_CHGIN_DTLS_MASK) >> 2)
But I guess these could use similar treatment?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-02-14 10:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 13:43 [PATCH v5 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-02-13 20:43 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-02-13 20:48 ` Rob Herring
2019-02-14 9:29 ` Bartosz Golaszewski
2019-02-14 10:37 ` Pavel Machek
2019-02-14 14:18 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-02-13 20:49 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-02-13 20:50 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-02-14 10:39 ` Pavel Machek [this message]
2019-02-14 10:42 ` Bartosz Golaszewski
2019-02-14 10:51 ` Pavel Machek
2019-02-13 13:43 ` [PATCH v5 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214103944.GC6132@amd \
--to=pavel@ucw.cz \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).