linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: mark.rutland@arm.com, linus.walleij@linaro.org,
	bgolaszewski@baylibre.com, orsonzhai@gmail.com,
	zhang.lyra@gmail.com, broonie@kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string
Date: Mon, 18 Feb 2019 14:07:38 -0600	[thread overview]
Message-ID: <20190218200737.GA7091@bogus> (raw)
In-Reply-To: <ad2fbe222ad715b3f7e6e093a7f822743e465f9a.1550201284.git.baolin.wang@linaro.org>

On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote:
> Change to use SoC compatible string instead of wildcard string.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> Changes from v1:
>  - None.
> ---
>  drivers/gpio/gpio-pmic-eic-sprd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index ac573da..24228cf 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id sprd_pmic_eic_of_match[] = {
> -	{ .compatible = "sprd,sc27xx-eic", },
> +	{ .compatible = "sprd,sc2731-eic", },

You need to keep the old one if you care about backwards compatibility. 
If you don't then state why in the commit message.

>  	{ /* end of list */ }
>  };
>  MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2019-02-18 20:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  4:55 [PATCH v2 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Baolin Wang
2019-02-15  4:55 ` [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string Baolin Wang
2019-02-18 20:07   ` Rob Herring [this message]
2019-02-19  2:02     ` Baolin Wang
2019-02-18 20:07 ` [PATCH v2 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218200737.GA7091@bogus \
    --to=robh@kernel.org \
    --cc=baolin.wang@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).