From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Chris Healy <cphealy@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: [PATCH 2/7] gpio: vf610: Simplify vf610_gpio_set()
Date: Sun, 10 Mar 2019 23:27:32 -0700 [thread overview]
Message-ID: <20190311062737.6652-3-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190311062737.6652-1-andrew.smirnov@gmail.com>
The only difference between two codepaths is register offset
used. Simplify the code a bit by replacing explicit calls with a
single call with a variable offset. No functional change intended.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-imx@nxp.com
---
drivers/gpio/gpio-vf610.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index 7e9451f47efe..2ea17870e9da 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -102,11 +102,9 @@ static void vf610_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
{
struct vf610_gpio_port *port = gpiochip_get_data(gc);
unsigned long mask = BIT(gpio);
+ unsigned long offset = val ? GPIO_PSOR : GPIO_PCOR;
- if (val)
- vf610_gpio_writel(mask, port->gpio_base + GPIO_PSOR);
- else
- vf610_gpio_writel(mask, port->gpio_base + GPIO_PCOR);
+ vf610_gpio_writel(mask, port->gpio_base + offset);
}
static int vf610_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)
--
2.20.1
next prev parent reply other threads:[~2019-03-11 6:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 6:27 [PATCH 0/7] VF610 GPIO fixes/improvments Andrey Smirnov
2019-03-11 6:27 ` [PATCH 1/7] gpio: vf610: Do not share irq_chip Andrey Smirnov
2019-03-11 6:27 ` Andrey Smirnov [this message]
2019-03-11 6:27 ` [PATCH 3/7] gpio: vf610: Simplify vf610_gpio_get() Andrey Smirnov
2019-03-11 6:27 ` [PATCH 4/7] gpio: vf610: Use devres to disable clk_port Andrey Smirnov
2019-03-11 6:27 ` [PATCH 5/7] gpio: vf610: Use devres to disable clk_gpio Andrey Smirnov
2019-03-11 6:27 ` [PATCH 6/7] gpio: vf610: Use devres to remove gpiochip Andrey Smirnov
2019-03-11 6:27 ` [PATCH 7/7] gpio: vf610: Don't use explicit &pdev->dev in vf610_gpio_probe() Andrey Smirnov
2019-03-11 9:55 ` [PATCH 0/7] VF610 GPIO fixes/improvments Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311062737.6652-3-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=cphealy@gmail.com \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).