From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
akpm@linux-foundation.org, linux-gpio@vger.kernel.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
geert@linux-m68k.org, preid@electromag.com.au,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro
Date: Thu, 28 Mar 2019 13:40:04 +0900 [thread overview]
Message-ID: <20190328044004.GB3251@icarus> (raw)
In-Reply-To: <20190327123314.GJ9224@smile.fi.intel.com>
On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote:
> > Replace verbose implementation in set_multiple callback with
> > for_each_set_clump8 macro to simplify code and improve clarity.
>
> > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) {
>
> > + bank = (chip->registers - 1) - (offset / 8);
>
> Excessive parens, but it's minor.
Fair point, this could do without parens around (chip->registers - 1).
Since this and renaming 'idx' to 'index' in find_bit.c are such a minor
changes, I'll wait first to see if something else comes up to be fixed
in this review. If so, I'll add these changes to the next version of
this patchset.
William Breathitt Gray
>
> > + bitmask = bitmap_get_value8(bits, offset) & bankmask;
> >
> > chip->buffer[bank] &= ~bankmask;
> > + chip->buffer[bank] |= bitmask;
> > }
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2019-03-28 4:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 4:57 [PATCH v13 00/11] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-03-27 4:58 ` [PATCH v13 01/11] bitops: " William Breathitt Gray
2019-03-27 6:42 ` Lukas Wunner
2019-03-28 4:30 ` William Breathitt Gray
2019-03-28 7:30 ` Lukas Wunner
2019-03-27 12:30 ` Andy Shevchenko
2019-03-27 4:59 ` [PATCH v13 02/11] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-03-27 4:59 ` [PATCH v13 03/11] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-03-27 4:59 ` [PATCH v13 04/11] gpio: 104-idi-48: " William Breathitt Gray
2019-03-27 5:00 ` [PATCH v13 05/11] gpio: gpio-mm: " William Breathitt Gray
2019-03-27 5:00 ` [PATCH v13 06/11] gpio: ws16c48: " William Breathitt Gray
2019-03-27 5:00 ` [PATCH v13 07/11] gpio: pci-idio-16: " William Breathitt Gray
2019-03-27 5:01 ` [PATCH v13 08/11] gpio: pcie-idio-24: " William Breathitt Gray
2019-03-27 5:02 ` [PATCH v13 09/11] gpio: uniphier: " William Breathitt Gray
2019-03-27 5:02 ` [PATCH v13 10/11] gpio: 74x164: Utilize the " William Breathitt Gray
2019-03-27 12:33 ` Andy Shevchenko
2019-03-28 4:40 ` William Breathitt Gray [this message]
2019-03-28 9:11 ` Andy Shevchenko
2019-03-27 5:02 ` [PATCH v13 11/11] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328044004.GB3251@icarus \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=preid@electromag.com.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).