* Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-03-13 14:20 [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X* Christina Quast
@ 2019-03-28 15:20 ` Rob Herring
2019-03-29 9:28 ` Aisheng Dong
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2019-03-28 15:20 UTC (permalink / raw)
Cc: aisheng.dong, festevam, shawnguo, stefan, kernel, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree, linux-kernel,
Christina Quast
On Wed, 13 Mar 2019 15:20:40 +0100, Christina Quast wrote:
> In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from
> the documentation.
>
> Changes since v2:
> * Changed patch title to 'dt-bindings: pinctrl: imx7d:'
>
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
> ---
> .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-03-13 14:20 [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X* Christina Quast
2019-03-28 15:20 ` Rob Herring
@ 2019-03-29 9:28 ` Aisheng Dong
2019-04-03 8:43 ` Shawn Guo
2019-04-08 12:08 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Aisheng Dong @ 2019-03-29 9:28 UTC (permalink / raw)
To: Christina Quast
Cc: festevam@gmail.com, shawnguo@kernel.org, stefan@agner.ch,
kernel@pengutronix.de, linus.walleij@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> From: Christina Quast [mailto:cquast@hanoverdisplays.com]
> Sent: Wednesday, March 13, 2019 10:21 PM
>
> In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from the
> documentation.
>
> Changes since v2:
> * Changed patch title to 'dt-bindings: pinctrl: imx7d:'
>
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
> ---
> .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> index 6666277c3acb..8ac1d0851a0f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> @@ -48,9 +48,9 @@ PAD_CTL_HYS (1 << 3)
> PAD_CTL_SRE_SLOW (1 << 2)
> PAD_CTL_SRE_FAST (0 << 2)
> PAD_CTL_DSE_X1 (0 << 0)
> -PAD_CTL_DSE_X2 (1 << 0)
> -PAD_CTL_DSE_X3 (2 << 0)
> -PAD_CTL_DSE_X4 (3 << 0)
> +PAD_CTL_DSE_X4 (1 << 0)
> +PAD_CTL_DSE_X2 (2 << 0)
> +PAD_CTL_DSE_X6 (3 << 0)
>
> Examples:
> While iomuxc-lpsr is intended to be used by dedicated peripherals to take
> --
> 2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-03-13 14:20 [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X* Christina Quast
2019-03-28 15:20 ` Rob Herring
2019-03-29 9:28 ` Aisheng Dong
@ 2019-04-03 8:43 ` Shawn Guo
2019-04-08 12:10 ` Linus Walleij
2019-04-08 12:08 ` Linus Walleij
3 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2019-04-03 8:43 UTC (permalink / raw)
To: linus.walleij, VI1PR04MB42227AA158BA1FCBF314AA27807B0
Cc: aisheng.dong, festevam, stefan, kernel, robh+dt, mark.rutland,
linux-gpio, devicetree, linux-kernel, Christina Quast
Hi Linus,
I assume this will go via your tree. Let me know if you think
differently.
Shawn
On Wed, Mar 13, 2019 at 03:20:40PM +0100, Christina Quast wrote:
> In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from
> the documentation.
>
> Changes since v2:
> * Changed patch title to 'dt-bindings: pinctrl: imx7d:'
>
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
> ---
> .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> index 6666277c3acb..8ac1d0851a0f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> @@ -48,9 +48,9 @@ PAD_CTL_HYS (1 << 3)
> PAD_CTL_SRE_SLOW (1 << 2)
> PAD_CTL_SRE_FAST (0 << 2)
> PAD_CTL_DSE_X1 (0 << 0)
> -PAD_CTL_DSE_X2 (1 << 0)
> -PAD_CTL_DSE_X3 (2 << 0)
> -PAD_CTL_DSE_X4 (3 << 0)
> +PAD_CTL_DSE_X4 (1 << 0)
> +PAD_CTL_DSE_X2 (2 << 0)
> +PAD_CTL_DSE_X6 (3 << 0)
>
> Examples:
> While iomuxc-lpsr is intended to be used by dedicated peripherals to take
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-04-03 8:43 ` Shawn Guo
@ 2019-04-08 12:10 ` Linus Walleij
2019-04-08 12:41 ` [EXT] " Aisheng Dong
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2019-04-08 12:10 UTC (permalink / raw)
To: Shawn Guo
Cc: VI1PR04MB42227AA158BA1FCBF314AA27807B0, Dong Aisheng,
Fabio Estevam, Stefan Agner, Sascha Hauer, Rob Herring,
Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org, Christina Quast
On Wed, Apr 3, 2019 at 10:43 AM Shawn Guo <shawnguo@kernel.org> wrote:
> I assume this will go via your tree. Let me know if you think
> differently.
OK I applied it, if you're not merging any device trees using
these defines this cycle it's fine I suppose.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [EXT] Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-04-08 12:10 ` Linus Walleij
@ 2019-04-08 12:41 ` Aisheng Dong
0 siblings, 0 replies; 7+ messages in thread
From: Aisheng Dong @ 2019-04-08 12:41 UTC (permalink / raw)
To: Linus Walleij, Shawn Guo
Cc: VI1PR04MB42227AA158BA1FCBF314AA27807B0@vi1pr04mb4222.eurprd04.prod.outlook.com,
Fabio Estevam, Stefan Agner, Sascha Hauer, Rob Herring,
Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org, Christina Quast
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: Monday, April 8, 2019 8:10 PM
> On Wed, Apr 3, 2019 at 10:43 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> > I assume this will go via your tree. Let me know if you think
> > differently.
>
> OK I applied it, if you're not merging any device trees using these defines this
> cycle it's fine I suppose.
>
IMX device tree does not use it.
So it's safe.
Regards
Dong Aisheng
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X*
2019-03-13 14:20 [PATCH v2] dt-bindings: pinctrl: imx7d: Fix PAD_CTL_DSE_X* Christina Quast
` (2 preceding siblings ...)
2019-04-03 8:43 ` Shawn Guo
@ 2019-04-08 12:08 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2019-04-08 12:08 UTC (permalink / raw)
To: VI1PR04MB42227AA158BA1FCBF314AA27807B0
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner,
Sascha Hauer, Rob Herring, Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org, Christina Quast
On Wed, Mar 13, 2019 at 3:20 PM Christina Quast
<cquast@hanoverdisplays.com> wrote:
> In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from
> the documentation.
>
> Changes since v2:
> * Changed patch title to 'dt-bindings: pinctrl: imx7d:'
>
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread