* [PATCH -next] pinctrl: artpec6: Make two functions static
@ 2019-03-21 15:09 Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yue Haibing @ 2019-03-21 15:09 UTC (permalink / raw)
To: jesper.nilsson, lars.persson, linus.walleij
Cc: linux-kernel, linux-gpio, linux-arm-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
symbol 'artpec6_pmx_enable' was not declared. Should it be static?
drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
symbol 'artpec6_pmx_disable' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
index d89dc43..e836850 100644
--- a/drivers/pinctrl/pinctrl-artpec6.c
+++ b/drivers/pinctrl/pinctrl-artpec6.c
@@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
}
}
-int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
- unsigned int group)
+static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
+ unsigned int function,
+ unsigned int group)
{
struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
@@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
return 0;
}
-void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
- unsigned int group)
+static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
+ unsigned int function,
+ unsigned int group)
{
struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] pinctrl: artpec6: Make two functions static
2019-03-21 15:09 [PATCH -next] pinctrl: artpec6: Make two functions static Yue Haibing
@ 2019-03-21 15:59 ` Jesper Nilsson
2019-04-04 15:26 ` Linus Walleij
2019-04-08 18:01 ` Nathan Chancellor
2 siblings, 0 replies; 6+ messages in thread
From: Jesper Nilsson @ 2019-03-21 15:59 UTC (permalink / raw)
To: Yue Haibing
Cc: jespern, larper, linus.walleij, linux-kernel, linux-gpio,
linux-arm-kernel
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] pinctrl: artpec6: Make two functions static
2019-03-21 15:09 [PATCH -next] pinctrl: artpec6: Make two functions static Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson
@ 2019-04-04 15:26 ` Linus Walleij
2019-04-08 18:01 ` Nathan Chancellor
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-04-04 15:26 UTC (permalink / raw)
To: Yue Haibing
Cc: Jesper Nilsson, Lars Persson, linux-kernel@vger.kernel.org,
open list:GPIO SUBSYSTEM, linux-arm-kernel
On Thu, Mar 21, 2019 at 10:09 PM Yue Haibing <yuehaibing@huawei.com> wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] pinctrl: artpec6: Make two functions static
2019-03-21 15:09 [PATCH -next] pinctrl: artpec6: Make two functions static Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson
2019-04-04 15:26 ` Linus Walleij
@ 2019-04-08 18:01 ` Nathan Chancellor
2019-04-09 1:35 ` YueHaibing
2019-04-09 6:56 ` Jesper Nilsson
2 siblings, 2 replies; 6+ messages in thread
From: Nathan Chancellor @ 2019-04-08 18:01 UTC (permalink / raw)
To: Yue Haibing
Cc: jesper.nilsson, lars.persson, linus.walleij, linux-kernel,
linux-gpio, linux-arm-kernel
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
On arm32 allyesconfig:
drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
'artpec6_pmx_disable' [-Werror,-Wunused-function]
This is the second time you've introduced an unused function warning by
making a function static[1], could you please be a little more vigilant
in your clean ups in the future?
[1]: https://lore.kernel.org/lkml/20190327050126.12064-1-natechancellor@gmail.com/
Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
send a patch doing so if that's the right course of action.
Thanks,
Nathan
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] pinctrl: artpec6: Make two functions static
2019-04-08 18:01 ` Nathan Chancellor
@ 2019-04-09 1:35 ` YueHaibing
2019-04-09 6:56 ` Jesper Nilsson
1 sibling, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-04-09 1:35 UTC (permalink / raw)
To: Nathan Chancellor
Cc: jesper.nilsson, lars.persson, linus.walleij, linux-kernel,
linux-gpio, linux-arm-kernel
On 2019/4/9 2:01, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warnings:
>>
>> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
>> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
>> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
>> index d89dc43..e836850 100644
>> --- a/drivers/pinctrl/pinctrl-artpec6.c
>> +++ b/drivers/pinctrl/pinctrl-artpec6.c
>> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
>> }
>> }
>>
>> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
>> - unsigned int group)
>> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
>> + unsigned int function,
>> + unsigned int group)
>> {
>> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>>
>> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
>> return 0;
>> }
>>
>> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
>> - unsigned int group)
>> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
>> + unsigned int function,
>> + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?
Sorry for this.
>
> [1]: https://lore.kernel.org/lkml/20190327050126.12064-1-natechancellor@gmail.com/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.
>
> Thanks,
> Nathan
>
>> {
>> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>>
>> --
>> 2.7.0
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] pinctrl: artpec6: Make two functions static
2019-04-08 18:01 ` Nathan Chancellor
2019-04-09 1:35 ` YueHaibing
@ 2019-04-09 6:56 ` Jesper Nilsson
1 sibling, 0 replies; 6+ messages in thread
From: Jesper Nilsson @ 2019-04-09 6:56 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Yue Haibing, jespern, larper, linus.walleij, linux-kernel,
linux-gpio, linux-arm-kernel
On Mon, Apr 08, 2019 at 11:01:10AM -0700, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> > -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> > - unsigned int group)
> > +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> > + unsigned int function,
> > + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?
>
> [1]: https://lore.kernel.org/lkml/20190327050126.12064-1-natechancellor@gmail.com/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.
Yes, that function is unused and can be dropped.
> Thanks,
> Nathan
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-09 6:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 15:09 [PATCH -next] pinctrl: artpec6: Make two functions static Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson
2019-04-04 15:26 ` Linus Walleij
2019-04-08 18:01 ` Nathan Chancellor
2019-04-09 1:35 ` YueHaibing
2019-04-09 6:56 ` Jesper Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).