From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-gpio@vger.kernel.org,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: gpio-omap: take pm_runtime usage while IRQs are claimed
Date: Wed, 10 Apr 2019 12:38:04 -0700 [thread overview]
Message-ID: <20190410193804.GM2839@atomide.com> (raw)
In-Reply-To: <4915fcdd-fb07-28c4-e530-d2559b8518ad@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [190410 18:17]:
> I'm very sorry, but what was the regression exactly?
> Can't enter RTC+DDR state? some crash?
AFAIK fails to enter RTC+DDR suspend because of conditional
PM runtime handling.
> We have in driver:
> irqc->parent_device = dev;
>
> which means:
> request_threaded_irq()
> irq_chip_pm_get()
> if (IS_ENABLED(CONFIG_PM) && data->chip->parent_device) {
> retval = pm_runtime_get_sync(data->chip->parent_device);
>
> and power.usage_count will be incremented every time GPIO irq is requested.
>
> only in free_irq() (or in case of error) power.usage_count is decremented.
>
> Now above change will introduce just another incrementation of power.usage_count
> How is it helping?
Oh OK, that means we can simplify things further and drop those
changes then. I'll post v2 version shortly with updated subject
and description.
Regards,
Tony
next prev parent reply other threads:[~2019-04-10 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 19:45 [PATCH] gpio: gpio-omap: take pm_runtime usage while IRQs are claimed Tony Lindgren
2019-04-09 4:36 ` Keerthy
2019-04-10 18:16 ` Grygorii Strashko
2019-04-10 19:38 ` Tony Lindgren [this message]
2019-04-10 21:27 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410193804.GM2839@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=bgolaszewski@baylibre.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).