From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Graeme Gregory <graeme.gregory@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 3/3] gpio: mb86s70: enable ACPI and irqchip support
Date: Thu, 25 Apr 2019 17:27:26 +0300 [thread overview]
Message-ID: <20190425142726.GA2583@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdacwYder5e0ik2T32heSBQhKvmbem8XMpUF0iShsw3D3w@mail.gmail.com>
On Thu, Apr 25, 2019 at 03:23:53PM +0200, Linus Walleij wrote:
> > - return ret;
> > + if (mb86s70_gpio_have_acpi(pdev))
> > + acpi_gpiochip_request_interrupts(&gchip->gc);
> > +
> > + return 0;
>
> I guess this is right...
>
> > struct mb86s70_gpio_chip *gchip = platform_get_drvdata(pdev);
> >
> > + if (gchip->gc.irq.domain) {
> > + acpi_gpiochip_free_interrupts(&gchip->gc);
> > + irq_domain_remove(gchip->gc.irq.domain);
> > + }
>
> Mika can possibly comment on the right way to do ACPI bring-up
> and take-down.
Only comment I have is that normally you don't need to call
acpi_gpiochip_request_interrupts() and acpi_gpiochip_free_interrupts()
in GPIO chip drivers itself. The core should take care of this if the
device ACPI description has an _AEI method.
next prev parent reply other threads:[~2019-04-25 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 10:20 [RFC PATCH 0/3] synquacer: implement ACPI gpio/interrupt support Ard Biesheuvel
2019-04-25 10:20 ` [RFC PATCH 1/3] irqchip/exiu: preparatory refactor for ACPI support Ard Biesheuvel
2019-04-25 10:20 ` [RFC PATCH 2/3] irqchip/exiu: implement ACPI gpiolib/irqchip support Ard Biesheuvel
2019-04-25 13:14 ` Linus Walleij
2019-04-25 15:33 ` Marc Zyngier
2019-04-26 8:24 ` Ard Biesheuvel
2019-04-26 8:44 ` Marc Zyngier
2019-04-26 11:45 ` Ard Biesheuvel
2019-04-26 22:27 ` Ard Biesheuvel
2019-04-29 9:09 ` Ard Biesheuvel
2019-04-29 9:35 ` Marc Zyngier
2019-04-25 10:20 ` [RFC PATCH 3/3] gpio: mb86s70: enable ACPI and irqchip support Ard Biesheuvel
2019-04-25 13:23 ` Linus Walleij
2019-04-25 13:35 ` Ard Biesheuvel
2019-04-25 14:27 ` Mika Westerberg [this message]
2019-04-26 8:19 ` Ard Biesheuvel
2019-04-26 9:15 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425142726.GA2583@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=masahisa.kojima@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).