From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI Date: Fri, 26 Apr 2019 15:23:17 +0300 Message-ID: <20190426122317.GP9224@smile.fi.intel.com> References: <20190405142112.26592-1-yuehaibing@huawei.com> <20190412151911.12084-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Yue Haibing , Bartosz Golaszewski , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List List-Id: linux-gpio@vger.kernel.org On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing wrote: > > > From: YueHaibing > > > > When building CONFIG_ACPI is not set > > gcc warn this: > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > put_device(&adev->dev); > > ^~ > > > > Reported-by: Hulk Robot > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > Suggested-by: Andy Shevchenko > > Signed-off-by: YueHaibing > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > so I assume it is supposed to be applied to the ACPI tree. > Acked-by: Linus Walleij Thanks! Rafael, can this be applied to your tree? -- With Best Regards, Andy Shevchenko